Page MenuHomePhabricator

Use standard WikimediaUI button appearance in Special:Log
Closed, ResolvedPublic

Description

As noted in T244824, naked buttons without mw-ui-button class has inconsistent style across cross-browser and they
look just plain weird on the mobile site (without any border, padding). Two buttons in Special:Log are like this, .mw-log-deleterevision-button and .mw-log-editchangetags-button. mw-ui-button class should be added to them for design consistency.

Event Timeline

Masumrezarock100 removed Volker_E as the assignee of this task.Feb 19 2020, 3:06 AM
Masumrezarock100 created this task.

@Zoranzoki21 wanna give a patch?

Masumrezarock100 added a comment.EditedFeb 19 2020, 3:11 AM

To clarify, I am talking about these two buttons. They look like plain text on the mobile site.

On the mobile siteOn desktop site

Screenshots taken from https://www.mediawiki.org/wiki/Special:Log.

This comment was removed by Kizule.
This comment was removed by Kizule.
Kizule claimed this task.EditedFeb 19 2020, 3:25 AM

Ok, I can make patch, no problem. This looks easy.

Just to note: I found this also when I want to delete/undelete some revision (With blue colour, I hid the part of summary and title because it contains the phone number)..

But looks like it needs to be converted to the OOUI firstly.

Restricted Application added a project: User-Kizule. · View Herald TranscriptFeb 19 2020, 3:25 AM
In T245584#5895750, @Zoranzoki21 wrote:

Ok, I can make patch, no problem. This looks easy.

Just to note: I found this also when I want to delete/undelete some revision (With blue colour, I hid the part of summary and title because it contains the phone number)..

But looks like it needs to be converted to the OOUI firstly.

Yup, it looks like the form in action=revisiondelete should be converted to OOUI.

In T245584#5895750, @Zoranzoki21 wrote:

Ok, I can make patch, no problem. This looks easy.

Just to note: I found this also when I want to delete/undelete some revision (With blue colour, I hid the part of summary and title because it contains the phone number)..

But looks like it needs to be converted to the OOUI firstly.

Yup, it looks like the form in action=revisiondelete should be converted to OOUI.

Task related to it is T117794: Convert Special:RevisionDelete to OOUI. I will make patch only for Special:Log.

Change 573061 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/core@master] Use standard Wikimedia button appearance in Special:Log

https://gerrit.wikimedia.org/r/573061

Volker_E renamed this task from Use standard Wikimedia button appearance in Special:Log to Use standard WikimediaUI button appearance in Special:Log.Feb 19 2020, 5:58 AM

Change 573061 merged by jenkins-bot:
[mediawiki/core@master] Use standard, cross-browser button appearance in Special:Log

https://gerrit.wikimedia.org/r/573061

Kizule closed this task as Resolved.Feb 19 2020, 6:14 AM

Patch merged, closing task as resolved :).