From mattermost
Also, it looks like that dashboard is missleading
EntityTermLookupBase increments metrics with wb_terms in the name, but the new code paths also use that base class, thus incrementing the wrong metrics
we should fix that as a priority
no point in having observability that lies to us
For the new store metrics matching the names of the new store should be used (as done elsewhere and displayed in the dashboard)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Addshore | T208425 [EPIC] Kill the wb_terms table | |||
| Resolved | Ladsgroup | T245592 EntityTermLookupBase imcrements wb_terms related metrics, but is now also used by the new term storage and should use different metric names. |
Change 573233 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move metrics out of EntityTermLookupBase.
Change 573241 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.19] Get rid of useless metrics in EntityTermLookupBase.
Change 573242 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.20] Get rid of useless metrics in EntityTermLookupBase.
Change 573233 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Get rid of useless metrics in EntityTermLookupBase.
Change 573242 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.20] Get rid of useless metrics in EntityTermLookupBase.
Change 573241 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.19] Get rid of useless metrics in EntityTermLookupBase.
Mentioned in SAL (#wikimedia-operations) [2020-02-19T11:06:04Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.19/extensions/Wikibase/lib/includes/Store: Get rid of useless metrics in EntityTermLookupBase (T245592) (duration: 01m 12s)
Mentioned in SAL (#wikimedia-operations) [2020-02-19T11:08:12Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.20/extensions/Wikibase/lib/includes/Store: Get rid of useless metrics in EntityTermLookupBase (T245592) (duration: 01m 04s)