CachingPrefetchingTermLookup should have a configurable TTL
Closed, ResolvedPublic
Actions

Description

Cache entries are currently set without any TTL which is bad when there are too many writes. CachingPrefetchingTermLookup is currently only used for Properties, but once it's enabled for items we likely need a TTL set to make sure the cache does not explode.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Wikibase	master	+44 -5	UncachedTermsPrefetcher: add configurable ttl

Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Feb 19 2020, 12:58 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 19 2020, 12:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 19 2020, 1:15 PM

Change 573306 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] UncachedTermsPrefetcher: add configurable ttl

https://gerrit.wikimedia.org/r/573306

gerritbot added a project: Patch-For-Review.Feb 19 2020, 3:20 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Feb 19 2020, 3:20 PM

Change 573306 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] UncachedTermsPrefetcher: add configurable ttl

https://gerrit.wikimedia.org/r/573306

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 4:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 19 2020, 5:00 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Feb 20 2020, 8:42 AM

Addshore closed this task as Resolved.Mar 4 2020, 4:11 PM