Page MenuHomePhabricator

disable WDQS jump to focus when used in an iframe
Closed, ResolvedPublic


When opening, there's a focus on the query field. This makes sense for users so they don't have to click on the field to start typing their query.

However, if a Query Service page is embedded in another web page through a html iframe, this focus jump will stay, causing some unpredictable issues (for example, jumping straight to the location of the embedded query in the page).

Reproduced here

We should find a way to disable this focus when the query page is embedded, while keeping it for users who access it through

Event Timeline

Change 573336 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Don’t autofocus editor when embedded

Change 573336 merged by jenkins-bot:
[wikidata/query/gui@master] Don’t autofocus editor when embedded

Note that this will need a new WDQS GUI deployment before it can be verified.

@Lucas_Werkmeister_WMDE we intended to deploy this fix but realized that the gui-deploy repo has not been updated yet with it, is there anything that still needs to be done for this task?

I think I was holding off on a build because I hoped Ide688bc7e7 might get reviewed/merged in time, but no luck. I’ll publish a new build.

So I guess it has not been deployed yesterday?

@Lucas_Werkmeister_WMDE deployment done, can you verify the fix on production?

Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Backlog to Done on the Wikidata Query UI board.

Seems to work great, thanks!