Page MenuHomePhabricator
Create Task
Maniphest T245652

Rvexludeuser not working when user is anon
Closed, ResolvedPublic
Actions

Description

In the last time rvexludeuser in a revision method of API is not working when user is anon. It’s a very serious bug, because it leads to the breakdown of many tools.

For example:

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+4 -6UserDef: Don't return incomplete UserIdentityValues
Customize query in gerrit

Event Timeline

Iluvatar created this task.Feb 19 2020, 5:53 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptFeb 19 2020, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Iluvatar triaged this task as High priority.Feb 19 2020, 5:54 PM
Riley_Huntley awarded a token.Feb 19 2020, 7:11 PM
gerritbot added a comment.Feb 19 2020, 8:21 PM

Change 573368 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] UserDef: Don't return incomplete UserIdentityValues

https://gerrit.wikimedia.org/r/573368

gerritbot added a project: Patch-For-Review.Feb 19 2020, 8:21 PM
Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Feb 19 2020, 8:21 PM
Anomie moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
Anomie claimed this task.Feb 19 2020, 8:25 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-API board.
gerritbot added a comment.Feb 20 2020, 5:46 PM

Change 573368 merged by jenkins-bot:
[mediawiki/core@master] UserDef: Don't return incomplete UserIdentityValues

https://gerrit.wikimedia.org/r/573368

Anomie closed this task as Resolved.Feb 20 2020, 6:00 PM

The fix should be deployed to Wikimedia sites with 1.35.0-wmf.21 or later. See https://www.mediawiki.org/wiki/MediaWiki_1.35/Roadmap for a tentative schedule.

If you want it out sooner, you're welcome to follow the process described at https://wikitech.wikimedia.org/wiki/SWAT_deploys#How_to_submit_a_patch_for_SWAT to have it backported to 1.35.0-wmf.20.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 20 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 20 2020, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL