Page MenuHomePhabricator
Create Task
Maniphest T245654

Remove 'new' indicator on Advance Mode option
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Advanced Mode option has had indicator long enough.

image.png (738×826 px, 64 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove 'new' indicator classmediawiki/extensions/MobileFrontendmaster+1 -1
Remove 'new' indicator styles on mobile optionsmediawiki/skins/MinervaNeuemaster+0 -13
Customize query in gerrit

Event Timeline

Volker_E created this task.Feb 19 2020, 6:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2020, 6:15 PM
gerritbot added a comment.Feb 19 2020, 6:24 PM

Change 573348 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Remove 'new' indicator styles on mobile options

https://gerrit.wikimedia.org/r/573348

gerritbot added a project: Patch-For-Review.Feb 19 2020, 6:24 PM
gerritbot added a comment.Feb 19 2020, 6:30 PM

Change 573349 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Remove 'new' indicator class

https://gerrit.wikimedia.org/r/573349

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.Feb 19 2020, 7:53 PM
Jdlrobson subscribed.

@ovasileva the above patch is pretty straightforward and IMO risk free. Perhaps we can estimate tomorrow?

ovasileva triaged this task as Medium priority.Feb 20 2020, 12:04 PM
Jdlrobson set the point value for this task to 2.Feb 24 2020, 9:35 PM

Via async estimation.

Jdlrobson reassigned this task from Volker_E to • alexhollender_WMF.Feb 24 2020, 9:36 PM
Jdlrobson moved this task from Upcoming to Needs Design Review on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.
gerritbot added a comment.Feb 24 2020, 9:49 PM

Change 573349 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove 'new' indicator class

https://gerrit.wikimedia.org/r/573349

gerritbot added a comment.Feb 24 2020, 9:52 PM

Change 573348 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove 'new' indicator styles on mobile options

https://gerrit.wikimedia.org/r/573348

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 24 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 24 2020, 10:11 PM
Jdlrobson added a comment.Feb 24 2020, 10:34 PM

Test uri: https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileOptions

Jdlrobson closed this task as Resolved.Feb 26 2020, 8:35 PM
Jdlrobson moved this task from Needs Design Review to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q3) board.

Per conversation after standup with Alex this is done and good.

Aklapper added projects: MobileFrontend, MinervaNeue.Feb 26 2020, 10:36 PM
Volker_E claimed this task.Feb 27 2020, 12:03 AM
Volker_E added a subscriber: • alexhollender_WMF.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits