⚓ T245682 Deprecate calling FileDeleteForm::doDelete without passing a user

Subject	Repo	Branch	Lines +/-
Deprecate calling FileDeleteForm::doDelete without passing a user	mediawiki/core	master	+4 -1
Tests: Pass a user to FileDeleteForm::doDelete	mediawiki/core	master	+3 -2
Pass a user to FileDeleteForm::doDelete	mediawiki/extensions/Nuke	master	+10 -2

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Resolved	MGChecker	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	MGChecker	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T242935 Deprecate core fallbacks to $wgUser
Resolved	DannyS712	T245682 Deprecate calling FileDeleteForm::doDelete without passing a user

DannyS712 created this task.Feb 19 2020, 10:30 PM

Change 573396 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Tests: Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573396

Change 573398 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573398

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Feb 19 2020, 10:37 PM

Change 573396 merged by jenkins-bot:
[mediawiki/core@master] Tests: Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573396

Change 573398 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573398

DannyS712 updated the task description. (Show Details)Feb 20 2020, 2:02 AM

DannyS712 removed a project: Patch-For-Review.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 573428 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate calling FileDeleteForm::doDelete without passing a user

https://gerrit.wikimedia.org/r/573428

gerritbot added a project: Patch-For-Review.Feb 20 2020, 2:50 AM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Feb 20 2020, 2:52 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 20 2020, 3:00 AM

Change 573428 merged by jenkins-bot:
[mediawiki/core@master] Deprecate calling FileDeleteForm::doDelete without passing a user

https://gerrit.wikimedia.org/r/573428

DannyS712 closed this task as Resolved.Feb 21 2020, 4:54 AM

DannyS712 removed a project: Patch-For-Review.

DannyS712 updated the task description. (Show Details)

DannyS712 mentioned this in T245802: Ensure all calls to FileDeleteForm::doDelete pass a user.Feb 21 2020, 4:59 AM

DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 23 2020, 10:22 AM