Page MenuHomePhabricator

Deprecate calling FileDeleteForm::doDelete without passing a user
Closed, ResolvedPublic

Description

Defaults to $wgUser
Deployed code: https://codesearch.wmflabs.org/deployed/?q=FileDeleteForm%3A%3AdoDelete&i=nope&files=&repos=

  • core: ApiUploadTestCase
  • core: UploadFromUrlTest
  • nuke: SpecialNuke
  • Actual hard deprecation

Event Timeline

Change 573396 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Tests: Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573396

Change 573398 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573398

Change 573396 merged by jenkins-bot:
[mediawiki/core@master] Tests: Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573396

Change 573398 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Pass a user to FileDeleteForm::doDelete

https://gerrit.wikimedia.org/r/573398

DannyS712 updated the task description. (Show Details)Feb 20 2020, 2:02 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 573428 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate calling FileDeleteForm::doDelete without passing a user

https://gerrit.wikimedia.org/r/573428

Change 573428 merged by jenkins-bot:
[mediawiki/core@master] Deprecate calling FileDeleteForm::doDelete without passing a user

https://gerrit.wikimedia.org/r/573428

DannyS712 closed this task as Resolved.Feb 21 2020, 4:54 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 updated the task description. (Show Details)