Page MenuHomePhabricator

Remove Revision::newNullRevision
Closed, ResolvedPublic

Description

Only remaining use is in MediaWiki-extensions-Duplicator, which has no compatibility policy and is used on sites that don't yet support the replacements (not new enough); not going to update it

https://codesearch.wmflabs.org/search/?q=Revision%3A%3AnewNullRevision&i=nope&files=&repos=

Event Timeline

DannyS712 changed the task status from Open to Stalled.Feb 20 2020, 2:14 AM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Cannot be actioned until 1.36

DannyS712 renamed this task from Remove support for calling Revision::newNullRevision without passing a user object to Remove Revision::newNullRevision.Apr 15 2020, 9:21 PM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)
DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:52 AM

Hi @DannyS712. I just saw this task. I've already started doing this in the https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Duplicator/+/644546, so your help would be great. 😃

Change 644546 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Duplicator@master] Make extension compatible with the MediaWiki 1.35 and newer

https://gerrit.wikimedia.org/r/644546

Change 644546 abandoned by Zoranzoki21:
[mediawiki/extensions/Duplicator@master] Make extension compatible with the MediaWiki 1.35 and newer

Reason:
Let's work on one by one option.

https://gerrit.wikimedia.org/r/644546

DannyS712 changed the task status from Open to Stalled.Dec 29 2020, 9:01 PM

Reflect decision to wait until 1.37 for Revision removals

This task was filed when I was not expecting to be able to remove the whole Revision class, sorry for the confusion. Resolving now that the entire class has been removed as part of T247143, see rMW983984d5d4a4: EPIC: Remove the Revision class entirely.