Page MenuHomePhabricator
Create Task
Maniphest T245704

Remove support for calling LogEventsList::userCan* functions without passing a user object
Closed, ResolvedPublic
Actions

Description

Hard deprecated in 1.35
Affected functions:

  • LogEventsList::userCan
  • LogEventsList::userCanBitfield
  • LogEventsList::userCanViewLogType

No known callers exist for any of these outside of core, so nothing more needs to be updated: https://codesearch.wmflabs.org/search/?q=LogEventsList%3A%3AuserCan&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Remove support for LogEventsList::userCan* functions without a usermediawiki/coremaster+9 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 changed the task status from Open to Stalled.Feb 20 2020, 2:17 AM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

Cannot be actioned until 1.36

DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM
DannyS712 moved this task from Next to Later on the User-DannyS712 board.Apr 13 2020, 9:13 PM
DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:52 AM
gerritbot added a comment.Sep 10 2020, 1:05 AM

Change 626250 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove support for LogEventsList::userCan* functions without a user

https://gerrit.wikimedia.org/r/626250

gerritbot added a project: Patch-For-Review.Sep 10 2020, 1:05 AM
DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.Sep 10 2020, 1:07 AM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).
gerritbot added a comment.Sep 10 2020, 3:50 PM

Change 626250 merged by jenkins-bot:
[mediawiki/core@master] Remove support for LogEventsList::userCan* functions without a user

https://gerrit.wikimedia.org/r/626250

Jdforrester-WMF closed this task as Resolved.Sep 10 2020, 3:51 PM
DannyS712 removed a project: Patch-For-Review.Sep 10 2020, 3:51 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 10 2020, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL