Page MenuHomePhabricator

Remove support for calling WikiPage::insertProtectNullRevision functions without passing a user object
Closed, InvalidPublic

Description

Hard deprecated in 1.35
All known callers already pass a user: https://codesearch.wmflabs.org/search/?q=-%3EinsertProtectNullRevision%5C(&i=nope&files=&repos=
Article::insertProtectNullRevision can be called without a user, and then pass that null user on. However, Article::insertProtectNullRevision is itself hard deprecated (see subtask), and so can be removed alongside removal of the $wgUser fallback

Event Timeline

DannyS712 changed the task status from Open to Stalled.Feb 20 2020, 2:22 AM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Cannot be actioned until 1.36

DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:52 AM
DannyS712 removed DannyS712 as the assignee of this task.
DannyS712 removed a project: User-DannyS712.

The entire method is now hard deprecated - see T250249: WikiPage::insertProtectNullRevision returns Revision objects