Remove support for calling PatrolLog::record without passing a user object
Closed, ResolvedPublic
Actions

Description

Hard deprecated in 1.35
All known callers already provide a user: https://codesearch.wmflabs.org/search/?q=PatrolLog%3A%3Arecord&i=nope&files=&repos=

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+3 -9	Remove support for PatrolLog::record without passing a user object

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T245331 Remove core fallbacks to global $wgUser [1.36]
Resolved	DannyS712	T245707 Remove support for calling PatrolLog::record without passing a user object

Event Timeline

Cannot be actioned until 1.36

DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM

DannyS712 moved this task from Next to Later on the User-DannyS712 board.Apr 13 2020, 9:12 PM

DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:52 AM

Change 623904 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove support for PatrolLog::record without passing a user object

https://gerrit.wikimedia.org/r/623904

gerritbot added a project: Patch-For-Review.Sep 3 2020, 8:36 PM

DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.Sep 3 2020, 8:38 PM

DannyS712 added a project: Platform Team Workboards (External Code Reviews).

Change 623904 merged by jenkins-bot:
[mediawiki/core@master] Remove support for PatrolLog::record without passing a user object

https://gerrit.wikimedia.org/r/623904

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 4 2020, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2020, 3:11 PM

daniel moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Sep 8 2020, 2:27 PM

DannyS712 closed this task as Resolved.Sep 8 2020, 3:56 PM