Page MenuHomePhabricator

ArticleEditUpdates deprecation log from FlaggedRevsHooks::onArticleEditUpdates spamming logs
Closed, ResolvedPublic


Noticed that after mw 1.35.0-wmf.20 to group1 the received logs jumped +1k/s, looks like there's ~10k entries for the message below, every ~5 minutes (I'm assuming due to jobs)

Use of ArticleEditUpdates hook (used in FlaggedRevsHooks::onArticleEditUpdates) was deprecated in MediaWiki 1.35. [Called from Hooks::run in /srv/mediawiki/php-1.35.0-wmf.19/includes/Hooks.php at line 202]

There's a throttle in place at the logstash level for duplicated messages, although it doesn't look like it is kicking in (fully?) in this case:

Event Timeline

T245175: FlaggedRevs uses hard deprecated ArticleEditUpdates hook should have fixed that - the hook should no longer be used in 1.35.0-wmf.20

Yeah, I'm happy to back-port the patch to wmf.19 if the level is too much; otherwise it should be gone from prod in ~4 hours' time when group2 rolls over to wmf.20.

(Also, odd that it seems caused by the wmf.20 pull forward to group1; possibly changes in Wikidata is resulting in client pages getting invalidated/re-painted and so having cascading impact?)

fgiunchedi claimed this task.

Can confirm that the message is indeed gone now as of latest deploy, thanks @Jdforrester-WMF ! Resolving in favor of T245778 which is still happening