Page MenuHomePhabricator
Create Task
Maniphest T245725

ArticleEditUpdates deprecation log from FlaggedRevsHooks::onArticleEditUpdates spamming logs
Closed, ResolvedPublic
Actions

Description

Noticed that after mw 1.35.0-wmf.20 to group1 the received logs jumped +1k/s, looks like there's ~10k entries for the message below, every ~5 minutes (I'm assuming due to jobs)

Use of ArticleEditUpdates hook (used in FlaggedRevsHooks::onArticleEditUpdates) was deprecated in MediaWiki 1.35. [Called from Hooks::run in /srv/mediawiki/php-1.35.0-wmf.19/includes/Hooks.php at line 202]

There's a throttle in place at the logstash level for duplicated messages, although it doesn't look like it is kicking in (fully?) in this case: https://logstash.wikimedia.org/goto/d74ea1c87e4f6f7ca96e2fbce43d2e00

Related Objects

Event Timeline

fgiunchedi created this task.Feb 20 2020, 10:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2020, 10:06 AM
DannyS712 added subscribers: Jdforrester-WMF, DannyS712.EditedFeb 20 2020, 10:18 AM

T245175: FlaggedRevs uses hard deprecated ArticleEditUpdates hook should have fixed that - the hook should no longer be used in 1.35.0-wmf.20

Jdforrester-WMF added a comment.Feb 20 2020, 4:43 PM

Yeah, I'm happy to back-port the patch to wmf.19 if the level is too much; otherwise it should be gone from prod in ~4 hours' time when group2 rolls over to wmf.20.

Jdforrester-WMF added a comment.Feb 20 2020, 4:47 PM

(Also, odd that it seems caused by the wmf.20 pull forward to group1; possibly changes in Wikidata is resulting in client pages getting invalidated/re-painted and so having cascading impact?)

herron mentioned this in T245778: Spike in "Use of ResourceLoaderSkinModule::getAvailableLogos with $wgLogoHD set instead of $wgLogos was deprecated in MediaWiki 1.35.".Feb 20 2020, 8:52 PM
fgiunchedi closed this task as Resolved.Feb 21 2020, 8:37 AM
fgiunchedi claimed this task.

Can confirm that the message is indeed gone now as of latest deploy, thanks @Jdforrester-WMF ! Resolving in favor of T245778 which is still happening

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL