While monitoring the terms storage situation closely while doing T219123 and T225057 I noticed that there qere some interesting read spikes, went digging and discovered they were directly caused by LUA
Spikes in getLabelWithLang calls:
Resulting increases on terms storage related methods:
Resulting increases in reads on s8 dbs:
We make the assumption that these getLabelWithLang calls are generally not unique and some are more popular than others. For example "the label of countries" used on infoboxes we would expect to be regularly used.
Thus we came to the conclusion that having this call backed by some cache would reduce the termstore lookups.