Page MenuHomePhabricator

[L] Add ability for CAT/Suggested Tags users to add additional tags (depicts statements)
Closed, ResolvedPublic

Description

User story: As a Suggested Tags user, I want the option to add a tag/depicts statement that is not currently in the suggested list, so that I can more accurately describe the image in the simple Suggested Tags interface I'm already using.

We have this:
Users of the Suggested Tags special page are presented with a list of suggested concepts contained in the image, but there's currently no way to add a tag that is not listed.

We want this:
Users should have the option of adding a tag that is not listed from the machine vision algorithm, using a simplified version of the existing depicts statement interface

Acceptance Criteria:

  • The Suggested Tags tool, both in Popular Uploads and User uploads, contains UI that allows users to search for and choose up to five additional Wikidata entities to use as tags
  • The feature works well on both desktop and mobile web, and could also work for our iOS/Android apps if they choose to utilize it
  • The interface for this is simplified - no need for qualifiers, marking as prominent, etc. The goal is to make this as straightforward as possible, like the rest of the existing interface
  • When a user adds additional tags, the item is removed from the queue

During development, please test the following:

  • Test this feature on at least one mobile browser
  • This feature will need Design QA

COVID-19 Deployment Criteria

  • Can you roll back this change without lasting impact?
    1. A recovery plan is required as this will help identify our capacity for recovering from the failure
    2. THIS IS A KEY QUESTION, if you can’t answer it, you shouldn’t deploy
  • Is specialized knowledge required to support this change in production? If so, are there multiple people with this knowledge?
  • Is there a way to increase confidence about the correctness of this change?
    1. Reviews (Design, Code, etc)
    2. Testing coverage (unit tests, integration tests)
    3. Manual testing (e.g. Beta, vagrant, docker)

Event Timeline

Cparle renamed this task from Add ability for CAT/Suggested Tags users to add additional tags (depicts statements) to [L] Add ability for CAT/Suggested Tags users to add additional tags (depicts statements).Feb 26 2020, 5:29 PM

Change 577666 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Enable users to add custom tags

https://gerrit.wikimedia.org/r/577666

Attaching the proposed design, which adds "+ Add tag" to the design which then prompts a dialog/overlay. The custom tag created will then be added at the end of the computer generated tags.

Please note that small visual changes might still be needed in order to differentiate "+ Add tag" from the generated tags (Possible changes include background color, text weights, or a pipe to separate the two).

Screen Shot 2020-03-19 at 12.16.58 PM.png (954×1 px, 1 MB)

mwilliams updated the task description. (Show Details)
mwilliams subscribed.
AnneT moved this task from Done to In development on the MachineVision board.

Change 577666 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Enable users to add custom tags

https://gerrit.wikimedia.org/r/577666

Working well on production.