Page MenuHomePhabricator
Create Task
Maniphest T245771

Adjust onboarding/offboarding logic to accommodate changes to #security (now acl*security)
Closed, ResolvedPublic
Actions

Description

My apologies for not noticing this would need to be done earlier.

The group that was once referenced with #security is now acl*security, and Security is now a group that will be open to all parties once we are ready.

The members of acl*security have also been moved to subprojects with meaningful names.

I know there is logic somewhere that needs to be updated, but I'm not sure where. These changes are in relation to T240490: Revamping Security-Team Work Intake and Flows and have been made in coordination with releng already.

Details

SubjectRepoBranchLines +/-
offboard-user: update script so that it can traverse subgroupsoperations/puppetproduction+43 -14
offboard-user: add acl*security to list of protected phab groupsoperations/puppetproduction+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• chasemp triaged this task as Medium priority.Feb 20 2020, 7:45 PM
• chasemp created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2020, 7:45 PM
• chasemp raised the priority of this task from Medium to Needs Triage.Feb 20 2020, 7:47 PM
• chasemp moved this task from Incoming to Watching on the Security-Team board.
• chasemp added a project: Security.

Setting to NT as I'm not sure what the ops workflow is and I don't want to jump over getting noticed with triage.

• chasemp renamed this task from Adjust onboarding/offboarding scirpts to accomodate subgroups of acl*security (and name change!) to Adjust onboarding/offboarding logic to accommodate changes to #security (now acl*security).Feb 20 2020, 7:48 PM
jbond claimed this task.Feb 21 2020, 11:42 AM
jbond triaged this task as Medium priority.
jbond added a subscriber: User-jbond.
gerritbot added a comment.Feb 21 2020, 1:43 PM

Change 573996 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] offboard-user: add acl*security to list of protected phab groups

https://gerrit.wikimedia.org/r/573996

gerritbot added a project: Patch-For-Review.Feb 21 2020, 1:43 PM
gerritbot added a comment.Feb 21 2020, 4:17 PM

Change 573996 merged by Jbond:
[operations/puppet@production] offboard-user: add acl*security to list of protected phab groups

https://gerrit.wikimedia.org/r/573996

jbond closed this task as Resolved.Feb 21 2020, 4:18 PM

@chasemp thanks for the heads up i have updated the offboarding script

• chasemp added a comment.Feb 21 2020, 4:21 PM
In T245771#5907231, @jbond wrote:

@chasemp thanks for the heads up i have updated the offboarding script

Cheers

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2020, 5:10 PM
jbond reopened this task as Open.Mar 3 2020, 5:05 PM

reopen this ticket as we need to ensure it handles the subgroups

jbond added a comment.Mar 5 2020, 11:11 AM

@chasemp can you please crate me a couple of test users so i can ensure the off boarding script is working as we expect.

Thanks John

• chasemp added a comment.Mar 5 2020, 4:45 PM
In T245771#5944399, @jbond wrote:

@chasemp can you please crate me a couple of test users so i can ensure the off boarding script is working as we expect.

Thanks John

https://phabricator.wikimedia.org/p/T245771_user_test_one/

https://phabricator.wikimedia.org/project/members/4560/

https://phabricator.wikimedia.org/p/T245771_user_test_two/

https://phabricator.wikimedia.org/project/members/4560/

https://phabricator.wikimedia.org/project/members/4567/

@jbond I created two users. The first is in one subgroup, the second is in multiple subgroups.

can you reassign this to me when all is well so I can make sure to disable those users as part of closing this task?

Thanks

gerritbot added a comment.Mar 6 2020, 1:07 PM

Change 577553 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] offboard-user: update script so that it can traverse subgroups

https://gerrit.wikimedia.org/r/577553

gerritbot added a project: Patch-For-Review.Mar 6 2020, 1:07 PM
gerritbot added a comment.Apr 2 2020, 10:36 AM

Change 577553 merged by Jbond:
[operations/puppet@production] offboard-user: update script so that it can traverse subgroups

https://gerrit.wikimedia.org/r/577553

jbond added a comment.Apr 2 2020, 10:42 AM

The script has been updated please feel free to test it further on mwmaint1002 and resolve the ticket

jbond removed jbond as the assignee of this task.Apr 2 2020, 10:43 AM
jbond subscribed.
Maintenance_bot removed a project: Patch-For-Review.Apr 2 2020, 11:10 AM
Aklapper added a comment.May 20 2020, 10:56 AM
In T245771#6022035, @jbond wrote:

The script has been updated please feel free to test it further on mwmaint1002 and resolve the ticket

Who wants to the be tester? (Only pinging so this task won't get forgotten.)

MoritzMuehlenhoff added a comment.May 20 2020, 11:56 AM

I think we can close the task, it'll be implicitly tested the next time we offboard someone with Security Phab acccess.

Aklapper added a project: User-jbond.Jun 1 2020, 9:58 AM
Aklapper removed a subscriber: User-jbond.
jbond closed this task as Resolved.Jun 1 2020, 10:57 AM
jbond claimed this task.

Resolve as per Moritz comment

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL