Page MenuHomePhabricator

Remove remaining WebRequest::getLimitOffset calls
Closed, ResolvedPublic

Description

...so that the function can be removed
::getLimitOffsetForUser should be used instead

Codesearch: https://codesearch.wmflabs.org/search/?q=getLimitOffset%5C(&i=nope&files=&repos=

[] RegexBlock not compatible with 1.35, see T243702: Make RegexBlock work with 1.35

On github, patches submitted but not a blocker, since they cannot be updated within gerrit / by WMF

On bitbucket, I'm not familiar with it and won't be submitting a patch to fix

  • wikiworksdev/CloneDiff

Event Timeline

DannyS712 triaged this task as Medium priority.Feb 20 2020, 8:51 PM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.

Change 573780 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ApprovedRevs@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573780

Change 573781 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Cargo@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573781

Change 573783 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CloneDiff@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573783

Change 573780 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573780

Change 573781 merged by jenkins-bot:
[mediawiki/extensions/Cargo@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573781

Change 573783 merged by Nischayn22:
[mediawiki/extensions/CloneDiff@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573783

Change 574078 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SemanticDrilldown@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/574078

Change 574083 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SpamRegex@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/574083

Change 574085 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UserPageViewTracker@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/574085

Change 574083 merged by jenkins-bot:
[mediawiki/extensions/SpamRegex@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/574083

Change 574078 merged by jenkins-bot:
[mediawiki/extensions/SemanticDrilldown@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/574078

Change 574085 merged by jenkins-bot:
[mediawiki/extensions/UserPageViewTracker@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/574085

DannyS712 updated the task description. (Show Details)

I've submitted github patches, but not updating those extensions shouldn't block this; marked as resolved

Note that semantic mediawiki, which is widely used, has merged the fix