Make Wikibase entities load and initialize lazily
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Feb 21 2020, 9:29 AM

Description

Calling ItemPage.get shouldn't be necessary. When the programmer asks for eg. ItemPage.claims, it should first take a look if the entity has been loaded, and if not, load it. This is what happens when page.text is used.
When the entity is loaded using ItemPage.get, all data is loaded and initialized, too. This creates potentially many unused objects in the memory (claims with values and sitelinks with site objects T226157). Let's only initialize those data attributes which the programmer cares about. Eventually, this could be more granular (eg. per property initialization).
- However, ItemPage.get is supposed to return a dictionary with all the data initialized. For backwards compatibility, it should become a "view" which will encapsulate all the above.

Details

	Subject	Repo	Branch	Lines +/-
	[IMPR] Create a SiteLink with __getitem__ method	pywikibot/core	master	+20 -12
	[IMPR] Load entities when necessary	pywikibot/core	master	+72 -7

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Amire80	T70071 [Compact links] Prioritise interwikis to featured pages
Declined		None	T70067 Tell in sitelink whether target is the "preferred" language for the topic/place of the article
Resolved		Addshore	T42810 Wikibase badges (tracking)
Resolved		Lokal_Profil	T128202 Implement badges support in pywikibot
Open		None	T186198 Changing qualifier value is blocked on NotImplementedError
Open		None	T186200 Rewrite Wikibase data model implementation
Open	Feature	None	T189321 Support for Lexicographical data/WikibaseLexeme in Pywikibot
Declined		Keegan	T180139 [Story] Support community/volunteer tools around Structured Commons
Declined		Keegan	T180197 [Epic] Support needed changes to volunteer tools for Wikimedia Commons and Wikidata that will benefit from operating with structured data on Commons
Invalid		None	T72936 Important tasks to be solved (tracking)
Resolved		Lokal_Profil	T66457 refactor sitelinks structure to support badges
Open	Feature	None	T223820 Properly implement structured data access on Commons in Pywikibot
Resolved		matej_suchanek	T213904 Implement file captions in Pywikibot
Resolved		Xqt	T273386 newitem.py has very long start
Resolved		Xqt	T238471 Performance problems with pywikibot's pagegenerator
Resolved		Xqt	T226157 Data retrieval may be very long and heavy because of parsing Link during SiteLink initialization
Open		None	T160395 Make Wikibase entity related code more flexible (tracking)
Resolved		matej_suchanek	T233406 Refactor Wikibase entities
Resolved		matej_suchanek	T245809 Make Wikibase entities load and initialize lazily

Event Timeline

matej_suchanek created this task.Feb 21 2020, 9:29 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 21 2020, 9:29 AM

matej_suchanek added parent tasks: T226157: Data retrieval may be very long and heavy because of parsing Link during SiteLink initialization, T233406: Refactor Wikibase entities.Feb 21 2020, 9:30 AM

matej_suchanek updated the task description. (Show Details)Feb 21 2020, 9:33 AM

Change 626640 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[pywikibot/core@master] [IMPR] Load entities when necessary

https://gerrit.wikimedia.org/r/626640

gerritbot added a project: Patch-For-Review.Sep 11 2020, 11:03 AM

Change 626640 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Load entities when necessary

https://gerrit.wikimedia.org/r/626640

matej_suchanek mentioned this in rPWBC20a03d272d42: [IMPR] Load entities when necessary.Sep 11 2020, 4:43 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2020, 5:10 PM

Xqt closed this task as Resolved.Jan 18 2021, 6:43 AM

Xqt assigned this task to matej_suchanek.