Page MenuHomePhabricator

Define required core parts of the Pronlex API
Closed, ResolvedPublic

Description

It seems that /lexicon/lookup is the only really required part of the lexicon API (mappers should be moved to another service, see T245821).
In the wikispeech mockup, lexicon/list is currently used as a test call, but perhaps the API should have a dedicated test call instead? (like, does this lexicon exisst and is it ready for lookup?)

API URLCalled by componentComment
lexicon/listlexicon_client.pyUsed in initialization tests
lexicon/lookuplexicon_client.pyUsed for lexicon lookup

All calls to lexicon server:

wikispeech_server/adapters/lexicon_client.py:169:       self.base_url = "%s/lexicon" % config.config.get("Services", "lexicon")
wikispeech_server/adapters/lexicon_client.py:175:       url = "%s/list" % self.base_url
wikispeech_server/adapters/lexicon_client.py:212:       url = "%s/%s?lexicons=%s&words=%s" % (self.base_url, "lookup", self.lexicon_name, encString)
wikispeech_server/adapters/mapper_client.py:16:         self.base_url = "%s/mapper" % config.config.get("Services", "lexicon")
wikispeech_server/adapters/mapper_client.py:22:         url = "%s/%s/%s/%s" % (self.base_url, "maptable", self.from_symbol_set, self.to_symbol_set)
wikispeech_server/adapters/mapper_client.py:40:         url = "%s/%s/%s/%s/%s" % (self.base_url, "map", self.from_symbol_set, self.to_symbol_set, string)
wikispeech_server/adapters/marytts_adapter.py:21:       mapper_url = config.config.get("Services", "lexicon")
wikispeech_server/adapters/marytts_adapter.py:610:      url = mapper_url+"/mapper/map/%s/%s/%s" % (from_symbol_set, to_symbol_set, quote(trans))
wikispeech_server/adapters/marytts_adapter.py:649:      url = mapper_url+"/mapper/map/%s/%s/%s" % (from_symbol_set, to_symbol_set, quote(trans))

Event Timeline

To clarify, this is the part of the Pronlex API that will be implemented on the MW side as well.

The conclusion from today's meeting, is that the only required part of the Pronlex API when used in readonly mode for TTS, is the function currently located here: /lexicon/lookup

The new API call will probably be added with a new prefix, because of:

  • to separate the public "readonly" API from other parts of the API
  • as defined in T245820, a higher level of abstraction may be required, and it's convenient to keep the old call as-is, and define the new API call separately
HannaLindgren reopened this task as Open.
HannaLindgren moved this task from Backlog to Done on the Wikispeech-Jobrunner (Sprint) board.
HannaLindgren renamed this task from Define required core parts of the Pronlex API to Define required core parts of the Pronlex API [done].Feb 21 2020, 12:27 PM

A subtask automatically inherits all project tags and subscribers. Just cleaning these up a bit. Feel free to re-add any which should not have been removed.

HannaLindgren renamed this task from Define required core parts of the Pronlex API [done] to Define required core parts of the Pronlex API.Feb 24 2020, 4:18 PM
HannaLindgren moved this task from Done to In progress on the Wikispeech-Jobrunner (Sprint) board.
HannaLindgren updated the task description. (Show Details)
HannaLindgren renamed this task from Define required core parts of the Pronlex API to Define required core parts of the Pronlex API [done].Feb 25 2020, 2:22 PM
HannaLindgren updated the task description. (Show Details)
HannaLindgren moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.
HannaLindgren renamed this task from Define required core parts of the Pronlex API [done] to Define required core parts of the Pronlex API.Feb 25 2020, 2:37 PM