Page MenuHomePhabricator

Log error on invalid configuration values
Closed, ResolvedPublic0 Estimated Story Points

Description

E.g. when WikispeechServerUrl is null or not a valid URL.

Event Timeline

Change 574468 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Log warning on invalid manifest configuration values

https://gerrit.wikimedia.org/r/574468

Lokal_Profil set the point value for this task to 2.Mar 11 2020, 1:37 PM

I've pulled master, rebased the branch, manually merged the conflicts, added them to git and then amended the commit.

For some reason this now depends on T203161 to be committed? I was too late? So should I wait for it to be pushed in, or should I rebase against that patch too?

kalle@musa:~/projekt/wikimedia/mediawiki/extensions/Wikispeech$ git review -R
You are about to submit multiple commits. This is expected if you are
submitting a commit that is dependent on one or more in-review
commits, or if you are submitting multiple self-contained but
dependent changes. Otherwise you should consider squashing your
changes into one commit before submitting (for indivisible changes) or
submitting from separate branches (for independent changes).

The outstanding commits are:

525e122 (HEAD -> T245823) Wikispeech: Log warning on invalid manifest configuration values
d8295e6 Add API action for requesting speech synthesis

Do you really want to submit the above commits?
Type 'yes' to confirm, other to cancel: yes
remote: 
remote: Processing changes: refs: 1
remote: Processing changes: refs: 1, done            
To ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikispeech
 ! [remote rejected] HEAD -> refs/for/master%topic=T245823 (cannot add patch set to 570042.)
error: failed to push some refs to 'ssh://karlwettin@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikispeech'

I got the patch to work by forcing my local master to sync with the remote. For some reason git fetch;git pull was not actually updating my master meaning any rebasing was not doing what was expected.

I left a note in the chat room about trying to figure out what caused it.

The way I figured out soething was wrong was by comparing the parent commit on the patch with the tip of the master branch (on gerrit)

I would not be surprised if more of the open patches have similar issues.

I just added a bit more to this patch.

See comment in https://gerrit.wikimedia.org/r/#/c/570042/

File includes/ApiWikispeechListen.php:

Patch Set #7, Line 22: $serverUrl = $config->get( 'WikispeechServerUrl' );

I'm not certain, is the onBeforePageDisplay hook executed prior to an API call and thus validating t […]

No, the BeforePageDisplay isn't run for the API. Could you make a follow up task to add the check to the API or add a note in the original log task?
kalle changed the point value for this task from 2 to 0.Apr 2 2020, 8:54 AM

Minor change required, Sebastian tells Kalle about it,
Kalle needs to give +2

Change 574468 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Log warning on invalid manifest configuration values

https://gerrit.wikimedia.org/r/574468

New hook already added to mw:Extension:Wikispeech. Don't believe anything else needs to be added ?

Added ApiBeforeMain on ext page

kalle moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.