E.g. when WikispeechServerUrl is null or not a valid URL.
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Log warning on invalid manifest configuration values | mediawiki/extensions/Wikispeech | master | +48 -3 |
Related Objects
- Mentioned In
- T203161: Restrict access to Wikispeech functionality to certain users
T249207: Switch from @codingStandardsIgnore to phpcs tags
T246085: Document re-architecturing decision (storage of utterances)
T244345: Remove the Util class for PHP tests
T244344: Remove the HtmlGenerator class
rEWIS7aa7556c5eb2: Log warning on invalid manifest configuration values - Mentioned Here
- T244344: Remove the HtmlGenerator class
T244345: Remove the Util class for PHP tests
T246085: Document re-architecturing decision (storage of utterances)
T249207: Switch from @codingStandardsIgnore to phpcs tags
rEWIS85fa89a53645: Wikispeech: Remove use of Utils.php
rEWISf79fe03b52eb: build: Updating acorn to 7.1.1
rEWIS956e50726f11: build: Updating minimist to 1.2.5
rEWIS66da277b9ca8: build: Updating mkdirp to 0.5.3
rEWIS18c20c760728: Add ADR "Store synthesized audio in MediaWiki extension"
rEWIS044eba0f5d54: Switch from @codingStandardsIgnore to phpcs tags
rEWIS2f98befc212a: Add API action for requesting speech synthesis
rEWIS43e26a230428: build: Updating postcss-sass to 0.4.4
rEWIS7aa7556c5eb2: Log warning on invalid manifest configuration values
T203161: Restrict access to Wikispeech functionality to certain users
Event Timeline
Change 574468 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Wikispeech: Log warning on invalid manifest configuration values
I've pulled master, rebased the branch, manually merged the conflicts, added them to git and then amended the commit.
For some reason this now depends on T203161 to be committed? I was too late? So should I wait for it to be pushed in, or should I rebase against that patch too?
kalle@musa:~/projekt/wikimedia/mediawiki/extensions/Wikispeech$ git review -R You are about to submit multiple commits. This is expected if you are submitting a commit that is dependent on one or more in-review commits, or if you are submitting multiple self-contained but dependent changes. Otherwise you should consider squashing your changes into one commit before submitting (for indivisible changes) or submitting from separate branches (for independent changes). The outstanding commits are: 525e122 (HEAD -> T245823) Wikispeech: Log warning on invalid manifest configuration values d8295e6 Add API action for requesting speech synthesis Do you really want to submit the above commits? Type 'yes' to confirm, other to cancel: yes remote: remote: Processing changes: refs: 1 remote: Processing changes: refs: 1, done To ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikispeech ! [remote rejected] HEAD -> refs/for/master%topic=T245823 (cannot add patch set to 570042.) error: failed to push some refs to 'ssh://karlwettin@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikispeech'
I got the patch to work by forcing my local master to sync with the remote. For some reason git fetch;git pull was not actually updating my master meaning any rebasing was not doing what was expected.
I left a note in the chat room about trying to figure out what caused it.
The way I figured out soething was wrong was by comparing the parent commit on the patch with the tip of the master branch (on gerrit)
I would not be surprised if more of the open patches have similar issues.
I just added a bit more to this patch.
See comment in https://gerrit.wikimedia.org/r/#/c/570042/
File includes/ApiWikispeechListen.php: Patch Set #7, Line 22: $serverUrl = $config->get( 'WikispeechServerUrl' ); I'm not certain, is the onBeforePageDisplay hook executed prior to an API call and thus validating t […] No, the BeforePageDisplay isn't run for the API. Could you make a follow up task to add the check to the API or add a note in the original log task?
Change 574468 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Log warning on invalid manifest configuration values
New hook already added to mw:Extension:Wikispeech. Don't believe anything else needs to be added ?