Page MenuHomePhabricator

Github Actions do not run correctly on Github mirrors of Gerrit-hosted repositories
Closed, ResolvedPublic

Description

WMDE would like to try out using Github Actions to automate post-merge workflows in one our repositories hosted on Gerrit and mirrored to wikimedia github.
Namely https://github.com/wikimedia/wikibase-vuejs-components, on Gerrit:https://gerrit.wikimedia.org/r/admin/projects/wikibase/vuejs-components

The initial workflow is at https://github.com/wikimedia/wikibase-vuejs-components/blob/master/.github/workflows/release.yaml

When the code is pushed to Github via Gerrit, Github Actions fail reporting the workflow error (see e.g. https://github.com/wikimedia/wikibase-vuejs-components/runs/460148633):

Pushing the same code directly to github results in Actions being run properly (this could be observed as "Verify and Publish" runs listed in https://github.com/wikimedia/wikibase-vuejs-components/actions)

At WMDE we believe the issue is due to the Gerrit "pushing" user's (https://github.com/wmfgerrit ?) config (said email address not being valid/verified).
Could someone verify that our theory is correct, and if so, adjust the email address config to allow using Github Actions in Gerrit mirrors?

If the approach we've taken is wrong, please advise what would be the better way to achieve the goal.
There seems to be no gerrit mirror set up to use Github Actions so far, so might be that we're doing it all wrong.

Event Timeline

WMDE-leszek added a subscriber: Jdforrester-WMF.

@Jdforrester-WMF If I remember correctly, you have been doing quite some stuff with Github Actions. Have you come across similar issue?

Reedy renamed this task from Github Actions do not run correctly on Github mirros of Gerrit-hosted repositories to Github Actions do not run correctly on Github mirrors of Gerrit-hosted repositories.Feb 21 2020, 2:31 PM

Assigning to Tyler to investigate setting an e-mail for wmfgerrit on GitHub.

That address is unverified because it does not exist it seems:

550 Address gerritadmin@wikimedia.org does not exist

I'm getting a group setup to manage this.

thcipriani subscribed.

At WMDE we believe the issue is due to the Gerrit "pushing" user's (https://github.com/wmfgerrit ?) config (said email address not being valid/verified).
Could someone verify that our theory is correct, and if so, adjust the email address config to allow using Github Actions in Gerrit mirrors?

That is the pushing user. That email address was not verified with github, but it should be as of a few minutes ago. Assigning back to @WMDE-leszek to check if this resolves the issue.

Change 593512 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikibase/vuejs-components@master] Update deployment instructions

https://gerrit.wikimedia.org/r/593512

Lucas_Werkmeister_WMDE reassigned this task from WMDE-leszek to thcipriani.

Tested with the v.0.1.8 release of our component library (workflow run), works like a charm. Thanks!

Change 593512 merged by jenkins-bot:
[wikibase/vuejs-components@master] Update deployment instructions

https://gerrit.wikimedia.org/r/593512