Remove conditional "federation mode" logic from the Wikibase API and hook code
Closed, ResolvedPublic
Actions

Description

Following T214557 and T245547 Wikibase code operates in the "entity source based federation" mode any way, hence the conditional logic is redundant.

Update RepoHooks: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/569334 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/569330
Update HtmlPageLinkRendererBeginHookHandler: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/572284
Update SearchEntities API class:
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/573347
- https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseCirrusSearch/+/574003

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikibaseCirrusSearch	master	+2 -0	Temporarily skip Search Entities integration tests

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		Addshore	T241975 entitysources: Remove old MultiRepository & PerRepository Service containers and config
		Resolved		WMDE-leszek	T245830 Remove conditional "federation mode" logic from the Wikibase API and hook code

Event Timeline

WMDE-leszek removed WMDE-leszek as the assignee of this task.Feb 21 2020, 2:13 PM

WMDE-leszek created this task.

WMDE-leszek moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 21 2020, 2:15 PM

WMDE-leszek mentioned this in T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config.Feb 21 2020, 2:16 PM

Change 574002 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseCirrusSearch@master] Temporarily skip Search Entities integration tests

https://gerrit.wikimedia.org/r/574002

gerritbot added a project: Patch-For-Review.Feb 21 2020, 2:58 PM

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 3:00 PM

WMDE-leszek triaged this task as High priority.Feb 21 2020, 3:55 PM

hoo updated the task description. (Show Details)Feb 21 2020, 5:16 PM

Change 574053 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Temporarily skip LexemeRdfBuilder tests

https://gerrit.wikimedia.org/r/574053

Change 574055 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily skip MediaInfoRdfBuilder tests

https://gerrit.wikimedia.org/r/574055

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 7:07 PM

Change 574002 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Temporarily skip Search Entities integration tests

https://gerrit.wikimedia.org/r/574002

WMDE-leszek mentioned this in T245860: Remove conditional "federation mode" logic from the Wikibase "top-level" factories.Feb 21 2020, 7:34 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 21 2020, 8:00 PM

WMDE-leszek mentioned this in rEWCS135b9a9c7cda: Temporarily skip Search Entities integration tests.Feb 21 2020, 8:03 PM

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 9:31 PM

WMDE-leszek updated the task description. (Show Details)Feb 22 2020, 6:04 PM

WMDE-leszek closed this task as Resolved.Feb 23 2020, 5:12 PM

WMDE-leszek claimed this task.

WMDE-leszek updated the task description. (Show Details)