Page MenuHomePhabricator
Create Task
Maniphest T245831

Remove conditional "federation mode" logic from the remaining "low-level" Wikibase code
Closed, ResolvedPublic
Actions

Description

Following T214557 and T245547 Wikibase code operates in the "entity source based federation" mode any way, hence the conditional logic is redundant.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek triaged this task as High priority.Feb 21 2020, 2:31 PM
WMDE-leszek created this task.
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
WMDE-leszek mentioned this in T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config.Feb 21 2020, 2:33 PM
WMDE-leszek updated the task description. (Show Details)
gerritbot added a comment.Feb 21 2020, 2:58 PM

Change 574003 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseCirrusSearch@master] Adjusted SearchEntities constructor in the integration test

https://gerrit.wikimedia.org/r/574003

gerritbot added a project: Patch-For-Review.Feb 21 2020, 2:58 PM

Change 573347 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed not needed "non-entity-source" logic in SearchEntities API class

https://gerrit.wikimedia.org/r/573347

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 21 2020, 3:15 PM
gerritbot added a comment.Feb 21 2020, 3:16 PM

Change 574007 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic from RepoLinker

https://gerrit.wikimedia.org/r/574007

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 3:16 PM
gerritbot added a comment.Feb 21 2020, 3:34 PM

Change 574012 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic from ValidatorBuilders

https://gerrit.wikimedia.org/r/574012

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 3:35 PM
gerritbot added a comment.Feb 21 2020, 3:43 PM

Change 574018 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed no longer used ForeignEntityValidator

https://gerrit.wikimedia.org/r/574018

gerritbot added a comment.Feb 21 2020, 4:35 PM

Change 574012 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic from ValidatorBuilders

https://gerrit.wikimedia.org/r/574012

gerritbot added a comment.Feb 21 2020, 4:38 PM

Change 574018 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed no longer used ForeignEntityValidator

https://gerrit.wikimedia.org/r/574018

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 4:42 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 21 2020, 5:00 PM
gerritbot added a comment.Feb 21 2020, 5:32 PM

Change 574007 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic from RepoLinker

https://gerrit.wikimedia.org/r/574007

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 5:33 PM
gerritbot added a comment.Feb 21 2020, 6:42 PM

Change 574054 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Define RdfVocabulary in LexemeRdfBuilder tests

https://gerrit.wikimedia.org/r/574054

gerritbot added a comment.Feb 21 2020, 6:46 PM

Change 574056 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseMediaInfo@master] Define RdfVocabulary in MediaInfoRfBuilder tests

https://gerrit.wikimedia.org/r/574056

gerritbot added a comment.Feb 21 2020, 6:55 PM

Change 574053 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Temporarily skip LexemeRdfBuilder tests

https://gerrit.wikimedia.org/r/574053

gerritbot added a comment.Feb 21 2020, 6:55 PM

Change 574055 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily skip MediaInfoRdfBuilder tests

https://gerrit.wikimedia.org/r/574055

gerritbot added a comment.Feb 21 2020, 6:57 PM

Change 574058 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseQualityConstraints@master] Temporarily skip SparqlHelper tests

https://gerrit.wikimedia.org/r/574058

gerritbot added a comment.Feb 21 2020, 6:57 PM

Change 574059 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseQualityConstraints@master] Adjusted RdfVocabulary constructor calls in SparqlHelperTest

https://gerrit.wikimedia.org/r/574059

gerritbot added a comment.Feb 21 2020, 6:59 PM

Change 574060 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RdfVocabulary

https://gerrit.wikimedia.org/r/574060

WMDE-leszek renamed this task from Remove conditional "federation mode" logic from remaning "low-level" Wikibase code to Remove conditional "federation mode" logic from the remaining "low-level" Wikibase code.Feb 21 2020, 7:09 PM
WMDE-leszek removed WMDE-leszek as the assignee of this task.
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Feb 21 2020, 7:31 PM

Change 573347 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed not needed "non-entity-source" logic in SearchEntities API class

https://gerrit.wikimedia.org/r/573347

WMDE-leszek mentioned this in T245860: Remove conditional "federation mode" logic from the Wikibase "top-level" factories.Feb 21 2020, 7:34 PM
gerritbot added a comment.Feb 23 2020, 2:18 PM

Change 574003 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Adjusted SearchEntities constructor in the integration test

https://gerrit.wikimedia.org/r/574003

WMDE-leszek mentioned this in rEWCS25119440f3c8: Adjusted SearchEntities constructor in the integration test.Feb 23 2020, 2:27 PM
gerritbot added a comment.Feb 24 2020, 10:07 AM

Change 574058 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Temporarily skip SparqlHelper tests

https://gerrit.wikimedia.org/r/574058

gerritbot added a comment.Feb 24 2020, 10:07 AM

Change 574055 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily skip MediaInfoRdfBuilder tests

https://gerrit.wikimedia.org/r/574055

gerritbot added a comment.Feb 24 2020, 10:07 AM

Change 574053 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Temporarily skip LexemeRdfBuilder tests

https://gerrit.wikimedia.org/r/574053

gerritbot added a comment.Feb 24 2020, 10:07 AM

Change 574060 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RdfVocabulary

https://gerrit.wikimedia.org/r/574060

WMDE-leszek updated the task description. (Show Details)Feb 24 2020, 10:15 AM
Jakob_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 25 2020, 10:17 AM
Addshore moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 4 2020, 4:12 PM

Still things to review here

gerritbot added a comment.Mar 4 2020, 6:18 PM

Change 574054 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Define RdfVocabulary in LexemeRdfBuilder tests

https://gerrit.wikimedia.org/r/574054

gerritbot added a comment.Mar 4 2020, 6:33 PM

Change 574059 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Adjusted RdfVocabulary constructor calls in SparqlHelperTest

https://gerrit.wikimedia.org/r/574059

hoo updated the task description. (Show Details)Mar 4 2020, 6:59 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Mar 4 2020, 7:00 PM
gerritbot added a comment.Mar 4 2020, 7:23 PM

Change 574056 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Define RdfVocabulary in MediaInfoRfBuilder tests

https://gerrit.wikimedia.org/r/574056

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2020, 8:10 PM
hoo updated the task description. (Show Details)Mar 4 2020, 10:50 PM
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:01 PM
Addshore closed this task as Resolved.Mar 6 2020, 1:59 PM
Addshore claimed this task.
Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 6 2020, 1:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits