Page MenuHomePhabricator
Create Task
Maniphest T245860

Remove conditional "federation mode" logic from the Wikibase "top-level" factories
Closed, ResolvedPublic
Actions

Description

Following T214557, T245547, T245817, T245830, and T245831 all Wikibase code operates in the "entity source based federation" mode any way, hence the conditional logic is redundant.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+0 -40Removed useEntitySourceBasedFederation from DataAccessSettings
mediawiki/extensions/Wikibasemaster+0 -4Removed DataAccessSettings::useEntitySourceBasedFederation
mediawiki/extensions/Wikibasemaster+65 -132Removed redundant "entity source federation mode" logic from WikibaseRepo
mediawiki/extensions/Wikibasemaster+0 -3Removed no longer needed globals from WikibaseClient entrypoint file
mediawiki/extensions/Wikibasemaster+24 -87Removed redundant "entity source federation mode" logic from WikibaseClient
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek triaged this task as High priority.Feb 21 2020, 7:34 PM
WMDE-leszek created this task.
WMDE-leszek moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
WMDE-leszek mentioned this in T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config.
gerritbot added a comment.Feb 21 2020, 8:04 PM

Change 574073 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed redundant "entity source federation mode" logic from WikibaseClient

https://gerrit.wikimedia.org/r/574073

gerritbot added a project: Patch-For-Review.Feb 21 2020, 8:04 PM

Change 574074 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed redundant "entity source federation mode" logic from WikibaseRepo

https://gerrit.wikimedia.org/r/574074

WMDE-leszek updated the task description. (Show Details)Feb 21 2020, 8:05 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 21 2020, 8:15 PM
WMDE-leszek mentioned this in T245865: Remove legacy Wikibase service containers.Feb 21 2020, 8:15 PM
WMDE-leszek mentioned this in T245870: Remove RepositorySettings.Feb 21 2020, 8:50 PM
gerritbot added a comment.Feb 22 2020, 5:46 PM

Change 574191 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed no longer needed globals from WikibaseClient entrypoint file

https://gerrit.wikimedia.org/r/574191

WMDE-leszek updated the task description. (Show Details)Feb 22 2020, 6:09 PM
gerritbot added a comment.Feb 22 2020, 6:12 PM

Change 574193 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed DataAccessSettings::useEntitySourceBasedFederation

https://gerrit.wikimedia.org/r/574193

gerritbot added a comment.Feb 22 2020, 6:19 PM

Change 574194 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Removed useEntitySourceBasedFederation from DataAccessSettings

https://gerrit.wikimedia.org/r/574194

WMDE-leszek removed WMDE-leszek as the assignee of this task.Feb 22 2020, 6:20 PM
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
gerritbot added a comment.Feb 24 2020, 10:07 AM

Change 574073 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed redundant "entity source federation mode" logic from WikibaseClient

https://gerrit.wikimedia.org/r/574073

gerritbot added a comment.Feb 24 2020, 10:07 AM

Change 574191 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed no longer needed globals from WikibaseClient entrypoint file

https://gerrit.wikimedia.org/r/574191

gerritbot added a comment.Feb 24 2020, 10:07 AM

Change 574074 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed redundant "entity source federation mode" logic from WikibaseRepo

https://gerrit.wikimedia.org/r/574074

WMDE-leszek updated the task description. (Show Details)Feb 24 2020, 10:15 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 24 2020, 11:00 AM
Jakob_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Feb 25 2020, 10:17 AM
Addshore moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Mar 4 2020, 4:12 PM

Still things to review

gerritbot added a comment.Mar 4 2020, 6:18 PM

Change 574193 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed DataAccessSettings::useEntitySourceBasedFederation

https://gerrit.wikimedia.org/r/574193

hoo updated the task description. (Show Details)Mar 4 2020, 6:56 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Mar 4 2020, 7:00 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Mar 5 2020, 10:42 AM
gerritbot added a comment.Mar 5 2020, 11:02 AM

Change 574194 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removed useEntitySourceBasedFederation from DataAccessSettings

https://gerrit.wikimedia.org/r/574194

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2020, 11:10 AM
Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:01 PM
Addshore closed this task as Resolved.Mar 6 2020, 1:59 PM
Addshore claimed this task.
Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 6 2020, 1:59 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL