Page MenuHomePhabricator
Create Task
Maniphest T245899

Fix missing name(aria-label) in Images - Gallery
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Navigate to VisualEditor
  2. Navigate to Insert
  3. Navigate till "Gallery " control, hit enter.
  4. Verify using Accessibility Insights tool

Actual Results:
Search Widget not accessible to screen readers

Expected Results:
Search Widget should be accessible to screen readers

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+6 -0MediaSearchWidget: Added aria-label for screen reader for the search input box
mediawiki/extensions/VisualEditormaster+5 -0Fix: Insert -> gallery dialog now contain label for screen readers
mediawiki/extensions/VisualEditormaster+5 -1Fix: Insert -> gallery dialog now contain label for screen readers
Customize query in gerrit

Event Timeline

Akinwale-microsoft created this task.Feb 22 2020, 1:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2020, 1:41 AM
gerritbot added a comment.Feb 22 2020, 1:41 AM

Change 574137 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/extensions/VisualEditor@master] Fix: Insert -> gallery dialog now contain label for screen readers

https://gerrit.wikimedia.org/r/574137

gerritbot added a project: Patch-For-Review.Feb 22 2020, 1:41 AM
gerritbot added a comment.Feb 24 2020, 9:53 PM

Change 574581 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/extensions/VisualEditor@master] Fix: Insert -> gallery dialog now contain label for screen readers

https://gerrit.wikimedia.org/r/574581

gerritbot added a comment.Feb 24 2020, 9:53 PM

Change 574137 abandoned by Akinwale-microsoft:
Fix: Insert -> gallery dialog now contain label for screen readers

Reason:
see new in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/ /574581

https://gerrit.wikimedia.org/r/574137

JTannerWMF added a project: Editing-team.Feb 25 2020, 4:17 PM
JTannerWMF added a subscriber: JTannerWMF.

We will consider this for code review in an upcoming sprint.

JTannerWMF moved this task from Incoming to Needs Prioritization on the Editing-team board.Feb 25 2020, 4:18 PM
gerritbot added a comment.Jul 9 2020, 4:46 AM

Change 610581 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Tam-edwin-microsoft):
[mediawiki/core@master] MediaSearchWidget: Added aria-label for screen reader for the search input box

https://gerrit.wikimedia.org/r/610581

Tam-edwin-microsoft added a comment.Jul 9 2020, 4:50 AM

Per Bartosz's comment in patch 574581 to move the change from VisualEditor to Mediawiki/core
I have uploaded the above new patch 610581

Tam-edwin-microsoft claimed this task.Jul 9 2020, 4:56 AM
Tam-edwin-microsoft added a subscriber: Bkudiess-msft.
gerritbot added a comment.Jul 13 2020, 8:32 PM

Change 574581 abandoned by Bartosz Dziewoński:
[mediawiki/extensions/VisualEditor@master] Fix: Insert -> gallery dialog now contain label for screen readers

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /610581

https://gerrit.wikimedia.org/r/574581

gerritbot added a comment.Jul 13 2020, 8:58 PM

Change 610581 merged by jenkins-bot:
[mediawiki/core@master] MediaSearchWidget: Added aria-label for screen reader for the search input box

https://gerrit.wikimedia.org/r/610581

matmarex renamed this task from Fix missing name(aria-label) in Images - Gallary to Fix missing name(aria-label) in Images - Gallery.Jul 13 2020, 8:59 PM
matmarex edited projects, added Editing-team (FY2020-21 Kanban Board); removed Editing-team.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 13 2020, 9:00 PM
ppelberg closed this task as Resolved.Jul 17 2020, 2:02 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 17 2020, 2:02 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL