Page MenuHomePhabricator

Set explicit text direction on talk page notifications
Closed, ResolvedPublic

Description

The Wikipedia Alpha Android app seems to have notifications about talk page mentions. This is awesome! A long-awaited feature.

I did find a little display bug with it: The text direction of the notifications appears to be set automatically, according to the first letter of the text. Or maybe it's even always LTR.

It should instead be set according to the user interface language of the app.

Here are a few screenshots that demonstrate the problem:

20200222_135526.jpg (903×1 px, 42 KB)

The above is a drawer notification about a talk page mention. The language's phone is Hebrew, and the notification comes from the Hebrew Wikipedia. Note that on the last line of the notification the full stop is on the right-hand end of the line. Since the text is right to left, the full stop is supposed to be on the left-hand end of the line.

Another example:

Screenshot_20200222-142046_Wikipedia Alpha.jpg (1×1 px, 321 KB)

This is the notifications archive. Notice how the usernames "Odder" and "Lucas Werkmeister" appear on the left-hand on the first line. They are supposed to appear on the right-hand end of the line, because they are in the beginning of the notification.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Charlotte lowered the priority of this task from Medium to Low.Feb 25 2020, 5:46 PM
JTannerWMF raised the priority of this task from Low to Medium.EditedJul 27 2021, 7:41 AM
JTannerWMF subscribed.

Since we are working on notifications and Arabic is a target language, which is right to left, the priority to fix this has increased and I am putting it in ready for dev

For the first part of this ticket description, it was an issue with the Android system UI instead of the app side, so there's nothing we can do at this time. Other than that, the issue should be fixed in the recently merged PR.