Page MenuHomePhabricator
Create Task
Maniphest T245940

Hard-deprecate and remove $wgContLang
Open, MediumPublic
Actions

Description

$wgContLang was deprecated in 1.32. It can easily be replaced with services, and MW-codesniffer already has a sniff to discourage usage. We should hard-deprecate and remove it.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Feb 23 2020, 11:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2020, 11:26 AM
Daimona added a parent task: T159283: Deprecate non-configuration globals.Feb 23 2020, 11:26 AM
gerritbot added a comment.Feb 23 2020, 11:26 AM

Change 574226 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/SpellingApi@master] Stop using deprecated $wgContLang

https://gerrit.wikimedia.org/r/574226

gerritbot added a project: Patch-For-Review.Feb 23 2020, 11:26 AM
gerritbot added a comment.Feb 23 2020, 1:19 PM

Change 566460 had a related patch set uploaded (by Daimona Eaytoy; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Stop using wgContLang in Client and Repo service factories

https://gerrit.wikimedia.org/r/566460

Daimona added a subtask: T241831: Remove use of $wgContLang in Scribunto.Feb 23 2020, 1:20 PM
gerritbot added a comment.Feb 23 2020, 1:26 PM

Change 574228 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Avoid using deprecated $wgContLang

https://gerrit.wikimedia.org/r/574228

gerritbot added a comment.Feb 23 2020, 1:29 PM

Change 574229 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Cargo@master] Don't use $wgContLang on MW 1.32+

https://gerrit.wikimedia.org/r/574229

gerritbot added a comment.Feb 23 2020, 2:30 PM

Change 566460 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop using wgContLang in Client and Repo service factories

https://gerrit.wikimedia.org/r/566460

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 23 2020, 3:00 PM
gerritbot added a comment.Feb 28 2020, 6:23 PM

Change 574228 merged by jenkins-bot:
[mediawiki/core@master] Avoid using deprecated $wgContLang

https://gerrit.wikimedia.org/r/574228

gerritbot added a comment.Feb 28 2020, 6:23 PM

Change 574226 merged by jenkins-bot:
[mediawiki/extensions/SpellingApi@master] Stop using deprecated $wgContLang

https://gerrit.wikimedia.org/r/574226

gerritbot added a comment.Feb 28 2020, 6:35 PM

Change 574229 merged by jenkins-bot:
[mediawiki/extensions/Cargo@master] Don't use $wgContLang on MW 1.32+

https://gerrit.wikimedia.org/r/574229

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 28 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 28 2020, 7:10 PM
gerritbot added a comment.Mar 13 2020, 8:16 PM

Change 579618 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/GlobalContribs@master] Bump MW version, remove deprecated $wgContLang() and IP class

https://gerrit.wikimedia.org/r/579618

gerritbot added a project: Patch-For-Review.Mar 13 2020, 8:16 PM
gerritbot added a comment.Mar 16 2020, 12:15 PM

Change 579919 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/DynamicPageList@master] Remove $wgContLang and $wgParser uses

https://gerrit.wikimedia.org/r/579919

gerritbot added a comment.Mar 18 2020, 8:25 PM

Change 579618 merged by GeorgeBarnick:
[mediawiki/extensions/GlobalContribs@master] Bump MW version, remove deprecated $wgContLang() and IP class

https://gerrit.wikimedia.org/r/579618

gerritbot added a comment.Mar 18 2020, 10:09 PM

Change 579919 merged by jenkins-bot:
[mediawiki/extensions/DynamicPageList@master] Remove $wgContLang and $wgParser uses

https://gerrit.wikimedia.org/r/579919

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2020, 10:10 PM
gerritbot added a comment.Mar 19 2020, 11:44 AM

Change 581544 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/EditNotify@master] Bump MW version, remove $wgParser and $wgContLang variables

https://gerrit.wikimedia.org/r/581544

gerritbot added a project: Patch-For-Review.Mar 19 2020, 11:44 AM
gerritbot added a comment.Mar 19 2020, 7:18 PM

Change 581544 merged by jenkins-bot:
[mediawiki/extensions/EditNotify@master] Bump MW version, remove $wgParser and $wgContLang variables

https://gerrit.wikimedia.org/r/581544

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2020, 8:10 PM
gerritbot added a comment.Apr 5 2020, 1:40 PM

Change 586080 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/NamespacePopups@master] Bump MW version, remove deprecated $wgContLang, update .gitignore

https://gerrit.wikimedia.org/r/586080

gerritbot added a project: Patch-For-Review.Apr 5 2020, 1:40 PM
gerritbot added a comment.Apr 6 2020, 10:30 PM

Change 586080 merged by jenkins-bot:
[mediawiki/extensions/NamespacePopups@master] Bump MW version, remove deprecated $wgContLang, update .gitignore

https://gerrit.wikimedia.org/r/586080

Maintenance_bot removed a project: Patch-For-Review.Apr 6 2020, 11:10 PM
QEDK mentioned this in rENPU7fcfac8f7a25: Bump MW version, remove deprecated $wgContLang, update .gitignore.Apr 7 2020, 12:11 AM
gerritbot added a comment.Apr 11 2020, 10:07 AM

Change 588078 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/News@master] Remove deprecated $wgContLang, $wgParser

https://gerrit.wikimedia.org/r/588078

gerritbot added a project: Patch-For-Review.Apr 11 2020, 10:07 AM
gerritbot added a comment.Apr 13 2020, 6:33 PM

Change 588078 merged by jenkins-bot:
[mediawiki/extensions/News@master] Remove deprecated $wgContLang, $wgParser

https://gerrit.wikimedia.org/r/588078

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2020, 7:10 PM
Krinkle triaged this task as Medium priority.Apr 21 2020, 3:54 PM
Krinkle moved this task from Untriaged to 2020 | MW 1.35 / 1.36 on the Technical-Debt (Deprecation process) board.
Krinkle added a parent task: T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).Apr 28 2020, 12:14 AM
Krinkle closed subtask T241831: Remove use of $wgContLang in Scribunto as Resolved.EditedApr 28 2020, 12:16 AM
Krinkle added a subscriber: Krinkle.

It looks like all use has been removed in wmf production. What's left are assignments (not read-outs) for compatibility with the code that no longer exists. (Codesearch)

Looks ripe for removal!

Krinkle removed a parent task: T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).Apr 30 2020, 1:41 AM
Krinkle mentioned this in T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).
Krinkle edited projects, added patch-welcome; removed MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).May 8 2020, 5:41 PM
gerritbot added a comment.May 8 2020, 6:16 PM

Change 595205 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Drop wgContLang, deprecated in 1.32

https://gerrit.wikimedia.org/r/595205

gerritbot added a project: Patch-For-Review.May 8 2020, 6:16 PM
Krinkle added a comment.May 13 2020, 5:11 PM
In T245940#6087417, @Krinkle wrote:

It looks like all use has been removed in wmf production. What's left are assignments (not read-outs) for compatibility with the code that no longer exists. (Codesearch)

Looks like two uses have emerged recently and/or previously missed:

  • CirrusSearch: $config->{get,set,has}( 'ContLang' ) (prod and test)
  • MobileFrontend: $config->get( 'ContLang' ) (prod)
gerritbot added a comment.May 13 2020, 5:32 PM

Change 596252 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MobileFrontend@master] Stop using deprecated wgContLang, about to be removed

https://gerrit.wikimedia.org/r/596252

gerritbot added a comment.May 13 2020, 5:36 PM

Change 596254 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CirrusSearch@master] Stop trying to write to deprecated global wgContLang, we're removing it

https://gerrit.wikimedia.org/r/596254

gerritbot added a comment.May 13 2020, 8:21 PM

Change 596252 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Stop using deprecated wgContLang, about to be removed

https://gerrit.wikimedia.org/r/596252

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 13 2020, 9:00 PM
gerritbot added a comment.May 20 2020, 10:36 PM

Change 596254 abandoned by Jforrester:
Stop trying to write to deprecated global wgContLang, we're removing it

Reason:
Sorry, yes, SiteConfiguration not SiteMatrix; but good to know that despite appearances this isn't related.

https://gerrit.wikimedia.org/r/596254

Krinkle mentioned this in T187154: Performance regression from Apcu/ExtensionRegistry::loadFromQueue on PHP7.Jun 9 2020, 6:52 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL