Page MenuHomePhabricator

Hard-deprecate and remove $wgContLang
Closed, ResolvedPublic

Description

$wgContLang was deprecated in 1.32. It can easily be replaced with services, and MW-codesniffer already has a sniff to discourage usage. We should hard-deprecate and remove it.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DataTransferREL1_36+8 -2
mediawiki/extensions/ArticleToCategory2REL1_36+5 -6
mediawiki/extensions/NSFileRepomaster+4 -3
mediawiki/extensions/QuickSearchLookupmaster+7 -3
mediawiki/skins/Schulenburgmaster+7 -2
mediawiki/extensions/Favoritesmaster+4 -2
mediawiki/extensions/FormatDatesmaster+5 -4
mediawiki/extensions/HelpCommonsmaster+3 -2
mediawiki/extensions/IndexFunctionmaster+3 -5
mediawiki/extensions/PageSchemasmaster+5 -5
mediawiki/extensions/PhpTagsSMWmaster+7 -7
mediawiki/extensions/Pushmaster+7 -7
mediawiki/extensions/S5SlideShowmaster+10 -8
mediawiki/extensions/SocialLoginmaster+7 -8
mediawiki/extensions/WikEdDiffmaster+6 -4
mediawiki/extensions/WikiLexicalDatamaster+3 -4
mediawiki/extensions/WebDAVmaster+0 -1
mediawiki/extensions/MintyDocsmaster+1 -2
mediawiki/extensions/SemanticInternalObjectsmaster+6 -5
mediawiki/extensions/DataTransfermaster+8 -2
mediawiki/extensions/PhpTagsFunctionsmaster+7 -16
mediawiki/extensions/TranslateSvgmaster+4 -4
mediawiki/extensions/DynamicPageListEnginemaster+8 -6
mediawiki/extensions/DidYouKnowmaster+5 -4
mediawiki/extensions/ConfirmAccountmaster+6 -8
mediawiki/extensions/Carpmaster+9 -7
mediawiki/extensions/ArticleToCategory2master+5 -6
mediawiki/extensions/TranslateSvgREL1_36+6 -6
mediawiki/extensions/RegexFunmaster+2 -2
mediawiki/extensions/PagesListREL1_36+3 -5
mediawiki/extensions/SelectCategoryREL1_36+4 -6
mediawiki/extensions/PolyglotREL1_36+13 -10
mediawiki/extensions/ReassignEditsREL1_36+5 -4
mediawiki/extensions/SemanticWebBrowsermaster+7 -5
mediawiki/extensions/PagesListmaster+3 -5
mediawiki/extensions/Polyglotmaster+13 -10
mediawiki/extensions/ReassignEditsmaster+5 -4
mediawiki/extensions/SelectCategorymaster+4 -6
mediawiki/extensions/I18nTagsmaster+18 -16
mediawiki/extensions/CirrusSearchmaster+2 -15
mediawiki/coremaster+16 -25
mediawiki/coremaster+31 -23
mediawiki/extensions/MobileFrontendmaster+4 -3
mediawiki/extensions/Newsmaster+13 -10
mediawiki/extensions/NamespacePopupsmaster+7 -4
mediawiki/extensions/EditNotifymaster+9 -6
mediawiki/extensions/DynamicPageListmaster+37 -33
mediawiki/extensions/GlobalContribsmaster+8 -6
mediawiki/extensions/Cargomaster+22 -6
mediawiki/coremaster+3 -2
mediawiki/extensions/SpellingApimaster+4 -3
mediawiki/extensions/Wikibasemaster+20 -24
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 596254 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CirrusSearch@master] Stop trying to write to deprecated global wgContLang, we're removing it

https://gerrit.wikimedia.org/r/596254

Change 596252 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Stop using deprecated wgContLang, about to be removed

https://gerrit.wikimedia.org/r/596252

Change 596254 abandoned by Jforrester:
Stop trying to write to deprecated global wgContLang, we're removing it

Reason:
Sorry, yes, SiteConfiguration not SiteMatrix; but good to know that despite appearances this isn't related.

https://gerrit.wikimedia.org/r/596254

Change 649595 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Don't access $wgRequest from User

https://gerrit.wikimedia.org/r/649595

Change 649595 merged by jenkins-bot:
[mediawiki/core@master] Don't access $wgRequest from User

https://gerrit.wikimedia.org/r/649595

Change 595205 merged by jenkins-bot:
[mediawiki/core@master] Drop wgContLang, deprecated in 1.32

https://gerrit.wikimedia.org/r/595205

I18nTags extension started causing fatals on translatewiki.net

Change 673043 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/I18nTags@master] Remove use of removed wgContLang

https://gerrit.wikimedia.org/r/673043

Change 673043 merged by jenkins-bot:
[mediawiki/extensions/I18nTags@master] Remove use of removed wgContLang

https://gerrit.wikimedia.org/r/673043

Change 690425 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SelectCategory@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690425

Change 690426 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReassignEdits@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690426

Change 690428 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/skins/Schulenburg@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690428

Change 690430 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ArticleToCategory2@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690430

Change 690431 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Carp@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690431

Change 690433 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmAccount@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690433

Change 690434 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DidYouKnow@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690434

Change 690435 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DynamicPageListEngine@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690435

Change 690436 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Favorites@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690436

Change 690437 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FormatDates@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690437

Change 690438 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/HelpCommons@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690438

Change 690439 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/IndexFunction@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690439

Change 690440 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/NSFileRepo@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690440

Change 690441 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageSchemas@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690441

Change 690442 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PagesList@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690442

Change 690444 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhpTagsFunctions@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690444

Change 690445 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhpTagsSMW@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690445

Change 690446 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Polyglot@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690446

Change 690447 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Push@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690447

Change 690448 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/QuickSearchLookup@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690448

Change 690449 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/RegexFun@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690449

Change 690450 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/S5SlideShow@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690450

Change 690451 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SocialLogin@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690451

Change 690452 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslateSvg@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690452

Change 690453 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikEdDiff@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690453

Change 690454 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiLexicalData@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690454

Change 690456 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WebDAV@master] Removed comment about $wgContLang

https://gerrit.wikimedia.org/r/690456

Change 690457 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SemanticWebBrowser@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690457

Change 690458 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SemanticInternalObjects@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690458

Change 690460 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MintyDocs@master] Replace removed $wgContLang by MintyDocsUtils::getContLang()

https://gerrit.wikimedia.org/r/690460

Change 690461 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DataTransfer@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690461

Change 690425 merged by jenkins-bot:

[mediawiki/extensions/SelectCategory@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690425

Change 690426 merged by jenkins-bot:

[mediawiki/extensions/ReassignEdits@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690426

Change 690446 merged by jenkins-bot:

[mediawiki/extensions/Polyglot@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690446

Change 690442 merged by jenkins-bot:

[mediawiki/extensions/PagesList@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690442

Change 690812 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Polyglot@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690812

Change 690813 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SelectCategory@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690813

Change 690814 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PagesList@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690814

Change 690818 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReassignEdits@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690818

Change 690457 merged by Umherirrender:

[mediawiki/extensions/SemanticWebBrowser@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690457

Change 690818 merged by jenkins-bot:

[mediawiki/extensions/ReassignEdits@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690818

Change 690812 merged by jenkins-bot:

[mediawiki/extensions/Polyglot@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690812

Change 690813 merged by jenkins-bot:

[mediawiki/extensions/SelectCategory@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690813

Change 690814 merged by jenkins-bot:

[mediawiki/extensions/PagesList@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690814

Change 690449 merged by Umherirrender:

[mediawiki/extensions/RegexFun@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690449

Change 691308 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslateSvg@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/691308

Change 691308 merged by jenkins-bot:

[mediawiki/extensions/TranslateSvg@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/691308

Change 690430 merged by jenkins-bot:

[mediawiki/extensions/ArticleToCategory2@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690430

Change 690431 merged by jenkins-bot:

[mediawiki/extensions/Carp@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690431

Change 690433 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690433

Change 690434 merged by jenkins-bot:

[mediawiki/extensions/DidYouKnow@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690434

Change 690435 merged by jenkins-bot:

[mediawiki/extensions/DynamicPageListEngine@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690435

Change 690452 merged by jenkins-bot:

[mediawiki/extensions/TranslateSvg@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690452

Change 690444 merged by jenkins-bot:

[mediawiki/extensions/PhpTagsFunctions@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690444

Change 690461 merged by jenkins-bot:

[mediawiki/extensions/DataTransfer@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690461

Change 690458 merged by jenkins-bot:

[mediawiki/extensions/SemanticInternalObjects@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690458

Change 690460 merged by jenkins-bot:

[mediawiki/extensions/MintyDocs@master] Replace removed $wgContLang by MintyDocsUtils::getContLang()

https://gerrit.wikimedia.org/r/690460

Change 690440 merged by jenkins-bot:

[mediawiki/extensions/NSFileRepo@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690440

Change 690456 merged by jenkins-bot:

[mediawiki/extensions/WebDAV@master] Removed comment about $wgContLang

https://gerrit.wikimedia.org/r/690456

Change 690454 merged by jenkins-bot:

[mediawiki/extensions/WikiLexicalData@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690454

Change 690453 merged by jenkins-bot:

[mediawiki/extensions/WikEdDiff@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690453

Change 690451 merged by jenkins-bot:

[mediawiki/extensions/SocialLogin@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690451

Change 690450 merged by jenkins-bot:

[mediawiki/extensions/S5SlideShow@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690450

Change 690448 merged by jenkins-bot:

[mediawiki/extensions/QuickSearchLookup@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690448

Change 690447 merged by jenkins-bot:

[mediawiki/extensions/Push@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690447

Change 690445 merged by jenkins-bot:

[mediawiki/extensions/PhpTagsSMW@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690445

Change 690441 merged by jenkins-bot:

[mediawiki/extensions/PageSchemas@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690441

Change 690439 merged by jenkins-bot:

[mediawiki/extensions/IndexFunction@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690439

Change 690438 merged by jenkins-bot:

[mediawiki/extensions/HelpCommons@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690438

Change 690437 merged by jenkins-bot:

[mediawiki/extensions/FormatDates@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690437

Change 690436 merged by jenkins-bot:

[mediawiki/extensions/Favorites@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690436

Change 690428 merged by jenkins-bot:

[mediawiki/skins/Schulenburg@master] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/690428

Change 697107 had a related patch set uploaded (by Universal Omega; author: Umherirrender):

[mediawiki/extensions/ArticleToCategory2@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/697107

Change 697107 merged by jenkins-bot:

[mediawiki/extensions/ArticleToCategory2@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/697107

Change 699525 had a related patch set uploaded (by Paladox; author: Umherirrender):

[mediawiki/extensions/DataTransfer@REL1_36] Replace removed $wgContLang by MediaWikiServices

https://gerrit.wikimedia.org/r/699525