Page MenuHomePhabricator

MagicNoCache extension / Error from line 13 of "MagicNoCache.hooks.php": Call to undefined method MagicWord::get()
Closed, ResolvedPublic

Description

Setup

Issue

/Main_Page Error from line 13 of /var/lib/mediawiki/extensions/MagicNoCache/MagicNoCache.hooks.php: Call to undefined method MagicWord::get()

Originally reported here.
Backtrace

#0 /var/lib/mediawiki/includes/Hooks.php(174): MagicNoCacheHooks::magicwordCheck(Parser, string, StripState)
#1 /var/lib/mediawiki/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#2 /var/lib/mediawiki/includes/parser/Parser.php(1501): Hooks::run(string, array)
#3 /var/lib/mediawiki/includes/parser/Parser.php(599): Parser->internalParse(string)
#4 /var/lib/mediawiki/includes/cache/MessageCache.php(1298): Parser->parse(string, Title, ParserOptions, boolean)
#5 /var/lib/mediawiki/includes/language/Message.php(1253): MessageCache->parse(string, Title, boolean, boolean, LanguageEn)
#6 /var/lib/mediawiki/includes/language/Message.php(881): Message->parseText(string)
#7 /var/lib/mediawiki/includes/language/Message.php(934): Message->toString(string)
#8 /var/lib/mediawiki/includes/skins/Skin.php(956): Message->parse()
#9 /var/lib/mediawiki/includes/skins/SkinTemplate.php(388): Skin->lastModified()
#10 /var/lib/mediawiki/includes/skins/SkinTemplate.php(219): SkinTemplate->prepareQuickTemplate()
#11 /var/lib/mediawiki/includes/OutputPage.php(2593): SkinTemplate->outputPage()
#12 /var/lib/mediawiki/includes/MediaWiki.php(978): OutputPage->output(boolean)
#13 /var/lib/mediawiki/includes/MediaWiki.php(991): MediaWiki->{closure}()
#14 /var/lib/mediawiki/includes/MediaWiki.php(534): MediaWiki->main()
#15 /var/lib/mediawiki/index.php(47): MediaWiki->run()
#16 {main}

Event Timeline

Should be easy enough to fix up,

  • The remaining static methods for MagicWord, deprecated in 1.32, were removed. These were MagicWord::get(), ::getSubstIDs(), ::getDoubleUnderscoreArray(), ::getVariableIDs(), and ::getCacheTTL(). Instead, use MagicWordFactory (via MediaWikiServices).

Change 574232 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/MagicNoCache@master] Update call to removed MagicWord::get()

https://gerrit.wikimedia.org/r/574232

Should be easy enough to fix up,

How cool is this! Great! Thank you, much appreciated!!!

Change 574232 merged by jenkins-bot:
[mediawiki/extensions/MagicNoCache@master] Update call to removed MagicWord::get()

https://gerrit.wikimedia.org/r/574232

Kghbln assigned this task to Reedy.