Page MenuHomePhabricator

[Development tooling] grunt stylelint gives false positives inside comments, attributed to the wrong line number (tracking upstream reports)
Open, LowPublicBUG REPORT

Description

The pre-commit step grunt stylelint (Less coding style rules) gave errors

  1. inside comments
  2. attributed to the wrong line number: T243116: stylelint reports invalid line numbers
Reported upstream:

https://github.com/stylelint/stylelint/issues/4616
https://github.com/stylelint/stylelint/issues/4617
https://github.com/stylelint/stylelint/issues/4298#issuecomment-590111620
Related:
https://github.com/stylelint/stylelint/issues/4411

Line 252:
	// "CSS Fonts Module Level 4's `system-ui` value has resulted in unresolved side-effects in certain OS/language combinations and is therefore not included as of now."
Error:
253:71  ×  Expected single quotes        string-quotes
Line 252:
	// CSS Fonts Module Level 4's `system-ui` value has resulted in unresolved side-effects in certain OS/language combinations and is therefore not included as of now.
Error:
267:78  ×  Unclosed string   CssSyntaxError
Line 252:
	// CSS Fonts Module Level 4 `system-ui` value has resulted in unresolved side-effects in certain OS/language combinations and is therefore not included as of now.
No error.
Line 253:
	-apple-system,        // 'San Francisco' – Safari 9+ macOS and iOS, Firefox macOS.
	'BlinkMacSystemFont', // 'San Francisco' – Chrome 48+ macOS and iOS.
Error:
224:52  ×  Unexpected unknown unit "+"   unit-no-unknown
225:52  ×  Unexpected unknown unit "+"   unit-no-unknown
Line 256:
	'Roboto',             // Webfont, Android 4.0
Error:
227:46  ×  Unexpected trailing zero(s)   number-no-trailing-zeros
Line 256:
	'Roboto',             // Webfont, Android 4.
Error:
227:44  ×  Unexpected unknown unit "."   unit-no-unknown
Line 256:
	'Roboto',             // Webfont, Android 4.0.
Error:
227:44  ×  Unexpected unknown unit "."   unit-no-unknown
227:46  ×  Unexpected trailing zero(s)   number-no-trailing-zeros
Line 282:
	// See  https://gerrit.wikimedia.org/r/c/wikimedia-ui-base/+/504224  "Amend monospace system font stack" -- Volker_E
Error:
253:71  ×  Expected single quotes        string-quotes