Page MenuHomePhabricator
Create Task
Maniphest T245959

WMF deployed extensions need uses of global $wgUser removed [tracking]
Closed, ResolvedPublic
Actions

Description

See parent task for reasoning, and child tasks for individual extensions

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/LiquidThreadsmaster+1 -1Remove mention of $wgUser in a comment
mediawiki/extensions/DonationInterfacemaster+4 -5Remove references to $wgUser in comments
mediawiki/extensions/ORESmaster+0 -1Remove $wgUser setting in ChangesListHooksHandlerTest
mediawiki/extensions/ProofreadPagemaster+0 -1Remove $wgUser setting in PageContentTest
mediawiki/extensions/WikibaseMediaInfomaster+1 -1Remove use of $wgUser in WBMIApiTestCase
mediawiki/extensions/PropertySuggestermaster+6 -4Remove $wgUser use in GetSuggestionsTest
mediawiki/extensions/JsonConfigmaster+2 -2Rename function parameters `$wgUser` to just `$user`
mediawiki/extensions/WikimediaMaintenancemaster+4 -3Reduce direct references to $wgUser
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 OpenNoneT159283 Deprecate non-configuration globals
 OpenDannyS712T159299 Deprecate and remove $wgUser
 ResolvedDannyS712T267861 [GOAL] Emit deprecation warnings reading from $wgUser
 ResolvedDannyS712T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
 ResolvedDannyS712T241575 PageTriage needs uses of global $wgUser removed
 ResolvedDannyS712T241582 GeoData needs use of global $wgUser replaced
 ResolvedDannyS712T241583 GettingStarted needs uses of global $wgUser replaced
 ResolvedDannyS712T241608 FlaggedRevs needs uses of global $wgUser replaced
 ResolvedDannyS712T241615 CentralNotice needs uses of global $wgUser replaced
 ResolvedDannyS712T241616 Collection needs uses of global $wgUser removed
 ResolvedDannyS712T241617 GlobalBlocking needs uses of global $wgUser removed
 OpenDannyS712T241618 GlobalCssJs needs uses of global $wgUser removed
 ResolvedDannyS712T241619 LiquidThreads needs uses of global $wgUser removed
 ResolvedDannyS712T241630 WikimediaIncubator needs uses of global $wgUser removed
 ResolvedDannyS712T241815 Nostalgia needs uses of global $wgUser removed
 ResolvedDannyS712T241903 TimedMediaHandler needs uses of global $wgUser removed
 ResolvedDannyS712T241911 WikibaseLexeme needs uses of global $wgUser removed
 ResolvedDannyS712T241912 Translate needs uses of global $wgUser removed
 ResolvedDannyS712T241915 Jade needs uses of global $wgUser removed
 ResolvedSilvan_WMDET241947 Stop using $wgUser in Wikibase
 ResolvedDannyS712T242557 GeoCrumbs needs uses of global $wgUser removed
 ResolvedDannyS712T242677 CodeReview needs uses of global $wgUser removed
 ResolvedDannyS712T242936 ConfirmEdit needs uses of global $wgUser removed
 StalledDannyS712T242994 CentralAuth needs uses of global $wgUser removed
 ResolvedPRODUCTION ERRORDannyS712T291515 PHP Deprecated: $wgUser reassignment detected [Called from MediaWiki\Extension\CentralAuth\Special\SpecialCentralLogin::execute]
 ResolvedDannyS712T243554 ArticlePlaceholder needs uses of global $wgUser removed
 ResolvedDannyS712T243577 OpenStackManager needs uses of global $wgUser removed
 ResolvedDannyS712T243732 Echo needs uses of global $wgUser removed
 ResolvedReedyT262110 ForeignWikiRequest uses $wgUser (causes test failure)
 ResolvedDannyS712T243733 LdapAuthentication needs uses of global $wgUser removed
 ResolvedDannyS712T243807 TorBlock needs uses of global $wgUser removed
 ResolvedDannyS712T243823 Newsletter needs uses of global $wgUser removed
 ResolvedDannyS712T243874 Thanks needs uses of global $wgUser removed
 ResolvedDannyS712T243922 UserMerge needs uses of global $wgUser removed
 OpenDannyS712T244112 MassMessage needs uses of global $wgUser removed
 ResolvedDannyS712T241924 PagedTiffHandler needs uses of global $wgUser removed
 ResolvedDannyS712T241923 SecurePoll needs uses of global $wgUser removed
 ResolvedTheDJT241952 WikiEditor needs uses of global $wgUser removed
 ResolvedDannyS712T241704 SpamBlacklist needs uses of global $wgUser removed
 ResolvedDaimonaT246733 AbuseFilter needs uses of global $wgUser removed
 ResolvedDannyS712T248550 Math extension needs uses of global $wgUser removed
 ResolvedDannyS712T262111 Flow uses $wgUser
 ResolvedDannyS712T262713 GWToolset needs uses of global $wgUser removed
 ResolvedDannyS712T262715 UploadWizard needs uses of $wgUser removed
 ResolvedDannyS712T262716 WikibaseQualityConstraints needs use of global $wgUser removed
 ResolvedDannyS712T262717 WikimediaMaintenance needs uses of global $wgUser removed

Event Timeline

DannyS712 triaged this task as Medium priority.Feb 23 2020, 10:17 PM
DannyS712 created this task.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 23 2020, 10:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 added subtasks: T241575: PageTriage needs uses of global $wgUser removed, T241582: GeoData needs use of global $wgUser replaced, T241583: GettingStarted needs uses of global $wgUser replaced, T241608: FlaggedRevs needs uses of global $wgUser replaced, T241615: CentralNotice needs uses of global $wgUser replaced, T241616: Collection needs uses of global $wgUser removed, T241617: GlobalBlocking needs uses of global $wgUser removed, T241618: GlobalCssJs needs uses of global $wgUser removed, T241619: LiquidThreads needs uses of global $wgUser removed, T241630: WikimediaIncubator needs uses of global $wgUser removed, T241815: Nostalgia needs uses of global $wgUser removed, T241903: TimedMediaHandler needs uses of global $wgUser removed, T241911: WikibaseLexeme needs uses of global $wgUser removed, T241912: Translate needs uses of global $wgUser removed, T241915: Jade needs uses of global $wgUser removed, T241947: Stop using $wgUser in Wikibase, T242557: GeoCrumbs needs uses of global $wgUser removed, T242677: CodeReview needs uses of global $wgUser removed, T242936: ConfirmEdit needs uses of global $wgUser removed, T242994: CentralAuth needs uses of global $wgUser removed, T243554: ArticlePlaceholder needs uses of global $wgUser removed, T243577: OpenStackManager needs uses of global $wgUser removed, T243732: Echo needs uses of global $wgUser removed, T243733: LdapAuthentication needs uses of global $wgUser removed, T243807: TorBlock needs uses of global $wgUser removed, T243823: Newsletter needs uses of global $wgUser removed, T243874: Thanks needs uses of global $wgUser removed, T243922: UserMerge needs uses of global $wgUser removed, T244112: MassMessage needs uses of global $wgUser removed, T241924: PagedTiffHandler needs uses of global $wgUser removed, T241923: SecurePoll needs uses of global $wgUser removed, T241952: WikiEditor needs uses of global $wgUser removed, T241704: SpamBlacklist needs uses of global $wgUser removed.Feb 23 2020, 10:29 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.
Aklapper added a project: MediaWiki-extensions-General.Feb 24 2020, 8:48 AM
TheDJ changed the status of subtask T241903: TimedMediaHandler needs uses of global $wgUser removed from Open to Stalled.Feb 24 2020, 9:28 AM
DannyS712 reopened subtask T241615: CentralNotice needs uses of global $wgUser replaced as Open.Feb 27 2020, 4:05 AM
DannyS712 closed subtask T241615: CentralNotice needs uses of global $wgUser replaced as Resolved.Feb 29 2020, 2:02 AM
DannyS712 closed subtask T241630: WikimediaIncubator needs uses of global $wgUser removed as Resolved.Mar 3 2020, 5:53 AM
DannyS712 closed subtask T241619: LiquidThreads needs uses of global $wgUser removed as Resolved.Mar 3 2020, 5:30 PM
DannyS712 closed subtask T241608: FlaggedRevs needs uses of global $wgUser replaced as Resolved.Mar 13 2020, 3:00 PM
DannyS712 closed subtask T243922: UserMerge needs uses of global $wgUser removed as Resolved.Mar 15 2020, 8:15 PM
DannyS712 closed subtask T241617: GlobalBlocking needs uses of global $wgUser removed as Resolved.Mar 28 2020, 8:27 PM
DannyS712 closed subtask T241923: SecurePoll needs uses of global $wgUser removed as Resolved.May 11 2020, 2:10 PM
DannyS712 moved this task from In progress to Projects on the User-DannyS712 board.May 11 2020, 7:12 PM
DannyS712 changed the status of subtask T242994: CentralAuth needs uses of global $wgUser removed from Open to Stalled.Jun 6 2020, 4:54 AM
gerritbot added a comment.Jun 10 2020, 2:57 AM

Change 604231 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/JsonConfig@master] Rename function parameters $wgUser to just $user

https://gerrit.wikimedia.org/r/604231

gerritbot added a project: Patch-For-Review.Jun 10 2020, 2:57 AM
gerritbot added a comment.Jun 10 2020, 3:00 AM

Change 604233 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@master] Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/604233

gerritbot added a comment.Jun 10 2020, 4:59 AM

Change 604231 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Rename function parameters $wgUser to just $user

https://gerrit.wikimedia.org/r/604231

gerritbot added a comment.Jun 10 2020, 4:59 AM

Change 604233 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Reduce direct references to $wgUser

https://gerrit.wikimedia.org/r/604233

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 10 2020, 5:00 AM
DannyS712 removed a project: Patch-For-Review.Jun 10 2020, 5:00 AM
Reedy added a subtask: T262111: Flow uses $wgUser.Sep 5 2020, 2:49 AM
Reedy mentioned this in T262111: Flow uses $wgUser.Sep 5 2020, 3:42 AM
gerritbot added a comment.Sep 10 2020, 10:53 PM

Change 626439 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/DonationInterface@master] Remove references to $wgUser in comments

https://gerrit.wikimedia.org/r/626439

gerritbot added a project: Patch-For-Review.Sep 10 2020, 10:53 PM
gerritbot added a comment.Sep 10 2020, 10:58 PM

Change 626440 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ORES@master] Remove $wgUser setting in ChangesListHooksHandlerTest

https://gerrit.wikimedia.org/r/626440

gerritbot added a comment.Sep 10 2020, 11:03 PM

Change 626441 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ProofreadPage@master] Remove $wgUser setting in PageContentTest

https://gerrit.wikimedia.org/r/626441

gerritbot added a comment.Sep 10 2020, 11:05 PM

Change 626442 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PropertySuggester@master] Remove $wgUser use in GetSuggestionsTest

https://gerrit.wikimedia.org/r/626442

gerritbot added a comment.Sep 10 2020, 11:14 PM

Change 626443 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove use of $wgUser in WBMIApiTestCase

https://gerrit.wikimedia.org/r/626443

gerritbot added a comment.Sep 11 2020, 3:05 PM

Change 626442 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Remove $wgUser use in GetSuggestionsTest

https://gerrit.wikimedia.org/r/626442

gerritbot added a comment.Sep 11 2020, 3:06 PM

Change 626443 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove use of $wgUser in WBMIApiTestCase

https://gerrit.wikimedia.org/r/626443

gerritbot added a comment.Sep 11 2020, 3:06 PM

Change 626441 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Remove $wgUser setting in PageContentTest

https://gerrit.wikimedia.org/r/626441

gerritbot added a comment.Sep 11 2020, 3:10 PM

Change 626440 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Remove $wgUser setting in ChangesListHooksHandlerTest

https://gerrit.wikimedia.org/r/626440

gerritbot added a comment.Sep 11 2020, 3:29 PM

Change 626439 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Remove references to $wgUser in comments

https://gerrit.wikimedia.org/r/626439

DannyS712 mentioned this in rEPSd76d97bbb1a3: Remove $wgUser use in GetSuggestionsTest.Sep 11 2020, 3:46 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 11 2020, 4:01 PM
DannyS712 reopened subtask T242677: CodeReview needs uses of global $wgUser removed as Open.Sep 11 2020, 7:01 PM
gerritbot added a comment.Sep 13 2020, 8:18 PM

Change 626893 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Remove mention of $wgUser in a comment

https://gerrit.wikimedia.org/r/626893

gerritbot added a comment.Sep 14 2020, 4:49 AM

Change 626893 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Remove mention of $wgUser in a comment

https://gerrit.wikimedia.org/r/626893

DannyS712 closed subtask T242677: CodeReview needs uses of global $wgUser removed as Resolved.Sep 14 2020, 5:03 AM
DannyS712 closed subtask T241915: Jade needs uses of global $wgUser removed as Resolved.Sep 14 2020, 5:29 AM
DannyS712 closed subtask T262716: WikibaseQualityConstraints needs use of global $wgUser removed as Resolved.Sep 14 2020, 5:00 PM
DannyS712 closed subtask T262715: UploadWizard needs uses of $wgUser removed as Resolved.Sep 15 2020, 12:55 AM
DannyS712 closed subtask T262717: WikimediaMaintenance needs uses of global $wgUser removed as Resolved.Sep 25 2020, 6:04 PM
DannyS712 added a parent task: T267861: [GOAL] Emit deprecation warnings reading from $wgUser.Nov 15 2020, 12:24 AM
Daimona closed subtask T246733: AbuseFilter needs uses of global $wgUser removed as Resolved.Dec 9 2020, 12:43 AM
DannyS712 closed subtask T243733: LdapAuthentication needs uses of global $wgUser removed as Resolved.Dec 10 2020, 3:30 PM
DannyS712 closed subtask T262713: GWToolset needs uses of global $wgUser removed as Resolved.Dec 14 2020, 8:45 PM
DannyS712 reopened subtask T246733: AbuseFilter needs uses of global $wgUser removed as Open.Dec 14 2020, 8:52 PM
DannyS712 closed subtask T246733: AbuseFilter needs uses of global $wgUser removed as Resolved.Dec 14 2020, 11:02 PM
DannyS712 closed subtask T262111: Flow uses $wgUser as Resolved.Dec 22 2020, 1:10 AM
DannyS712 closed subtask T248550: Math extension needs uses of global $wgUser removed as Resolved.Dec 29 2020, 8:40 PM
DannyS712 changed the status of subtask T241903: TimedMediaHandler needs uses of global $wgUser removed from Stalled to Open.Jun 24 2021, 1:19 PM
Jdforrester-WMF closed subtask T241903: TimedMediaHandler needs uses of global $wgUser removed as Resolved.Jun 28 2021, 1:22 PM
DannyS712 closed subtask T243732: Echo needs uses of global $wgUser removed as Resolved.Jul 15 2021, 4:09 AM
DannyS712 closed this task as Resolved.Sep 4 2021, 5:36 AM
DannyS712 removed a project: Patch-For-Review.

All remaining uses of $wgUser in deployed extensions are needed for writes, and won't be removed until after the deprecation notices are emitted for reading, see T267861 for details. We will have a separate task for removing the few writes later (GlobalCssJs, MassMessage, and CentralAuth)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL