Page MenuHomePhabricator

SqliteInstallerTest::testCheckDataDir fails on php7.4, OS: macOS Catalina
Closed, ResolvedPublic

Description

Motivation

composer.phar phpunit:unit -- --exclude-group Broken,ParserFuzz,Stub

Fails with the following info:

  1. SqliteInstallerTest::testCheckDataDir

Trying to access array offset on value of type bool

/Users/peter/work/Wiki/gerrit/mediawiki/includes/installer/Installer.php:671
/Users/peter/work/Wiki/gerrit/mediawiki/includes/installer/SqliteInstaller.php:153
/Users/peter/work/Wiki/gerrit/mediawiki/tests/phpunit/unit/includes/installer/SqliteInstallerTest.php:30
/Users/peter/work/Wiki/gerrit/mediawiki/tests/phpunit/MediaWikiUnitTestCase.php:103

Expected Result

All tests should pass.

Addntional Info

LocalSetting.php:

## Database settings
$wgDBtype = "sqlite";
$wgDBserver = "";
$wgDBname = "my_wiki";
$wgDBuser = "";
$wgDBpassword = "";

# SQLite-specific settings
$wgSQLiteDataDir = "/Users/*...*/data";
$wgObjectCaches[CACHE_DB] = [
	'class' => SqlBagOStuff::class,
	'loggroup' => 'SQLBagOStuff',
	'server' => [
		'type' => 'sqlite',
		'dbname' => 'wikicache',
		'tablePrefix' => '',
		'variables' => [ 'synchronous' => 'NORMAL' ],
		'dbDirectory' => $wgSQLiteDataDir,
		'trxMode' => 'IMMEDIATE',
		'flags' => 0
	]
];
$wgLocalisationCacheConf['storeServer'] = [
	'type' => 'sqlite',
	'dbname' => "{$wgDBname}_l10n_cache",
	'tablePrefix' => '',
	'variables' => [ 'synchronous' => 'NORMAL' ],
	'dbDirectory' => $wgSQLiteDataDir,
	'trxMode' => 'IMMEDIATE',
	'flags' => 0
];

Event Timeline

Change 574432 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] database: Prevent installer from crashing when process group can't be determined

https://gerrit.wikimedia.org/r/574432

Change 574432 merged by jenkins-bot:
[mediawiki/core@master] database: Prevent installer from crashing when process group can't be determined

https://gerrit.wikimedia.org/r/574432