Page MenuHomePhabricator

Sqlite Integration tests fail on macOS php 7.4
Closed, ResolvedPublic

Description

Motivation

The 6 integration tests fail on SQLite db driver:
composer.phar phpunit:integration -- --exclude-group Broken,ParserFuzz,Stub --filter DatabaseSqliteTest
with output like:

1) DatabaseSqliteTest::testUpgrades
Default values does not match for column filearchive.fa_actor upgrading from 1.15 to 1.35.0-alpha
Failed asserting that '0' matches expected null.

/Users/peter/work/Wiki/gerrit/mediawiki/tests/phpunit/integration/includes/db/DatabaseSqliteTest.php:398
/Users/peter/work/Wiki/gerrit/mediawiki/tests/phpunit/MediaWikiIntegrationTestCase.php:416

2) DatabaseSqliteTest::testNativeInsertSupport with data set #0 ('3.7.11', 'a', array(1), 'INSERT  INTO a (a_1) VALUES ('1');')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'INSERT  INTO a (a_1) VALUES ('1');'
+'INSERT  INTO a (a_1) VALUES (1);'
FAILURES!
Tests: 39, Assertions: 403, Failures: 5.
Script phpunit --colors=always --testsuite=core:integration,extensions:integration,skins:integration handling the phpunit:integration event returned with error code 1

Expected Result

All tests should pass.

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2020, 1:48 PM
Peter.ovchyn updated the task description. (Show Details)Feb 24 2020, 1:48 PM
Peter.ovchyn updated the task description. (Show Details)

Change 574703 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] sqlite: Fix broken integration tests for SQLite db driver

https://gerrit.wikimedia.org/r/574703

Fixed 4 out of 5 tests related to data representation.

FAILURES!
Tests: 42, Assertions: 407, Failures: 1, Risky: 1.
Script phpunit --colors=always --testsuite=core:integration,extensions:integration,skins:integration handling the phpunit:integration event returned with error code 1

Change 574703 merged by jenkins-bot:
[mediawiki/core@master] sqlite: Fix broken integration tests for SQLite db driver

https://gerrit.wikimedia.org/r/574703

Anomie closed this task as Resolved.Feb 26 2020, 9:31 PM

I'm going to close this as Resolved since T246077 exists for the remaining issue.