Sqlite Integration tests fail on macOS php 7.4
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Peter.ovchyn
	Feb 24 2020, 1:48 PM

Description

Motivation

The 6 integration tests fail on SQLite db driver:
composer.phar phpunit:integration -- --exclude-group Broken,ParserFuzz,Stub --filter DatabaseSqliteTest
with output like:

1) DatabaseSqliteTest::testUpgrades
Default values does not match for column filearchive.fa_actor upgrading from 1.15 to 1.35.0-alpha
Failed asserting that '0' matches expected null.

/Users/peter/work/Wiki/gerrit/mediawiki/tests/phpunit/integration/includes/db/DatabaseSqliteTest.php:398
/Users/peter/work/Wiki/gerrit/mediawiki/tests/phpunit/MediaWikiIntegrationTestCase.php:416

2) DatabaseSqliteTest::testNativeInsertSupport with data set #0 ('3.7.11', 'a', array(1), 'INSERT  INTO a (a_1) VALUES ('1');')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'INSERT  INTO a (a_1) VALUES ('1');'
+'INSERT  INTO a (a_1) VALUES (1);'

FAILURES!
Tests: 39, Assertions: 403, Failures: 5.
Script phpunit --colors=always --testsuite=core:integration,extensions:integration,skins:integration handling the phpunit:integration event returned with error code 1

Expected Result

All tests should pass.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+10 -7	sqlite: Fix broken integration tests for SQLite db driver

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Peter.ovchyn	T245995 Sqlite Integration tests fail on macOS php 7.4
Resolved	Peter.ovchyn	T246076 Wrong definition of MW_ENTRY_POINT when integration tests run.
Resolved	aaron	T246077 SQlite has wrong DB structure after upgrading to 1.35
Invalid	Peter.ovchyn	T246078 Add SQLite infra to Jenkins CI

Event Timeline

Peter.ovchyn created this task.Feb 24 2020, 1:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2020, 1:48 PM

Peter.ovchyn updated the task description. (Show Details)Feb 24 2020, 1:48 PM

Peter.ovchyn updated the task description. (Show Details)

Aklapper added projects: SQLite, MediaWiki-General.Feb 24 2020, 2:43 PM

Peter.ovchyn moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Feb 24 2020, 5:08 PM

Change 574703 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] sqlite: Fix broken integration tests for SQLite db driver

https://gerrit.wikimedia.org/r/574703

gerritbot added a project: Patch-For-Review.Feb 25 2020, 9:40 AM

Fixed 4 out of 5 tests related to data representation.

FAILURES!
Tests: 42, Assertions: 407, Failures: 1, Risky: 1.
Script phpunit --colors=always --testsuite=core:integration,extensions:integration,skins:integration handling the phpunit:integration event returned with error code 1

Peter.ovchyn moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Feb 26 2020, 8:02 AM

daniel added subscribers: Anomie, Ladsgroup.Feb 26 2020, 10:31 AM

Anomie closed subtask T246078: Add SQLite infra to Jenkins CI as Invalid.Feb 26 2020, 4:55 PM

Anomie mentioned this in T246077: SQlite has wrong DB structure after upgrading to 1.35.Feb 26 2020, 4:57 PM

Change 574703 merged by jenkins-bot:
[mediawiki/core@master] sqlite: Fix broken integration tests for SQLite db driver

https://gerrit.wikimedia.org/r/574703