Page MenuHomePhabricator
Create Task
Maniphest T246043

[BUG REPORT] Reply tool's automatic edit summary use the wiki's content language
Closed, ResolvedPublic
Actions

Description

Compare the edit summary in https://nl.wikipedia.org/w/index.php?diff=55713383&oldid=55713375 against the edit summary in https://nl.wikipedia.org/w/index.php?diff=prev&oldid=55696385

Generally, on a language-specific content wiki (e.g., enwiki or nlwiki), I'd expect the edit summary to use that wiki's language. At a multi-lingual wiki (e.g., Meta-Wiki or mw.org), it might be nice to do it the other way.

Details

SubjectRepoBranchLines +/-
controller: Make edit summary use the wiki's content languagemediawiki/extensions/DiscussionToolsmaster+28 -1
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Feb 24 2020, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2020, 9:20 PM
PiefPafPier subscribed.Feb 25 2020, 7:30 AM

All West Frisian (fy) wikis are in Dutch (nl) since today (not logged in). Is this related? The language tool indicates 'Frysk' though ... (?)

H78c67c mentioned this in T246071: Interface language using Accept-Language header value instead of $wgLanguageCode.Feb 25 2020, 8:41 AM
JTannerWMF renamed this task from Should the Reply tool's automatic edit summary use my user-interface language, or the wiki's content language? to [BUG REPORT] Reply tool's automatic edit summary use my user-interface language, or the wiki's content language.Feb 25 2020, 4:38 PM
JTannerWMF added a project: Editing-team.
matmarex renamed this task from [BUG REPORT] Reply tool's automatic edit summary use my user-interface language, or the wiki's content language to [BUG REPORT] Reply tool's automatic edit summary use the wiki's content language.Feb 25 2020, 4:38 PM
JTannerWMF renamed this task from [BUG REPORT] Reply tool's automatic edit summary use the wiki's content language to [BUG REPORT] Reply tool's automatic edit summary use my user-interface language, or the wiki's content language.Feb 25 2020, 4:38 PM
JTannerWMF added a project: (DEPRECATED) Bug-Report.
matmarex renamed this task from [BUG REPORT] Reply tool's automatic edit summary use my user-interface language, or the wiki's content language to [BUG REPORT] Reply tool's automatic edit summary use the wiki's content language.Feb 25 2020, 4:39 PM
JTannerWMF added a project: OWC2020 (OWC2020 Replying 1.0).Feb 25 2020, 4:39 PM
JTannerWMF moved this task from Needs Prioritization to Required after release on the OWC2020 (OWC2020 Replying 1.0) board.
PiefPafPier unsubscribed.Feb 25 2020, 6:11 PM
• ppelberg edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team.Mar 5 2020, 1:10 AM
• ppelberg moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex claimed this task.Mar 10 2020, 12:30 PM
gerritbot added a comment.Mar 10 2020, 1:07 PM

Change 578521 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] controller: Make edit summary use the wiki's content language

https://gerrit.wikimedia.org/r/578521

gerritbot added a project: Patch-For-Review.Mar 10 2020, 1:07 PM
matmarex moved this task from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 10 2020, 1:08 PM
gerritbot added a comment.Mar 14 2020, 3:47 PM

Change 578521 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] controller: Make edit summary use the wiki's content language

https://gerrit.wikimedia.org/r/578521

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 14 2020, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 14 2020, 4:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 15 2020, 5:11 PM
matmarex added a project: Editing QA.
JTannerWMF moved this task from Inbox to High Priority on the Editing QA board.Mar 17 2020, 11:43 AM
Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 20 2020, 10:13 PM
Ryasmeen subscribed.

Doesn't look fixed:

Screen Shot 2020-03-20 at 3.13.01 PM.png (385×1 px, 115 KB)

Ryasmeen removed a project: Editing QA.Mar 20 2020, 10:14 PM
matmarex added a comment.Mar 20 2020, 10:20 PM

That's a diff from February, it should be fixed now.

matmarex added a comment.Mar 20 2020, 10:21 PM

(The existing edit summaries can't be fixed, only new ones.)

Ryasmeen moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 20 2020, 10:44 PM
In T246043#5988418, @matmarex wrote:

(The existing edit summaries can't be fixed, only new ones.)

Got it! :) Looks okay then.

• ppelberg closed this task as Resolved.Mar 24 2020, 12:39 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 24 2020, 12:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL