Page MenuHomePhabricator

Special:WantedTemplates cronjob not running on all wikis
Closed, ResolvedPublic

Description

Based on https://github.com/wikimedia/puppet/blob/master/modules/mediawiki/manifests/maintenance/updatequerypages/enwiki/cronjob.pp#L42 it should be running on the 20th of every month. According to https://en.wikipedia.org/wiki/Special:WantedTemplates it hasn't run since november.

Maybe someone with access could check to see what /var/log/mediawiki/updateSpecialPages/cron-updatequerypages-wantedtemplates-s1-WantedTemplates.log says on mwmaint1002

Actually it looks like all the --only special pages have stopped working sometime in early december (including one's not in the enwiki file). Special pages on the normal 3 day roatation still seem to work. There was a change in october (d59d853d9cc9) but it looks like it didn't break until a bit after that. cc'ing @Ladsgroup anyways.

Original report at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=942511738#We_need_to_update_maintenance_reports_at_least_weekly

Event Timeline

04:10 < Lucas_WMDE> bawolff: /var/log/mediawiki/updateSpecialPages/updatequerypages-enwiki-only-WantedTemplates.log 
                    exists but is very short (“Fatal error: no version entry for `#`”)
04:10 < Urbanecm> bawolff: did you mean /var/log/mediawiki/updateSpecialPages/s1@11-WantedPages.log?
04:10 < Lucas_WMDE> same for the file Urbanecm mentioned

I can also show you the whole file, it doesn’t look sensitive:

-------------------------------------
#
-------------------------------------
no version entry for `#`.
Fatal error: no version entry for `#`.
 in /srv/mediawiki/multiversion/MWMultiVersion.php on line 424

The only file with a different sha256sum in that directory is /var/log/mediawiki/updateSpecialPages/s8@18-MostLinked.log:

-------------------------------------
wikidatawiki
-------------------------------------
Mostlinked                     [QueryPage] /usr/local/bin/mwscript: line 26: 115249 Killed                  $PHP "$MEDIAWIKI_DEPLOYMENT_DIR_DIR_USE/multiversion/MWScript.php" "$@"

Change 574726 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/puppet@production] make mwscriptwikiset respect comments set in dblists

https://gerrit.wikimedia.org/r/574726

The issue is mwscriptwikiset being broken, because it doesn't respect comments recently introduced in dblists. My patch should fix that.

Timestamps of when this start failing match up with the patch that introduced comments on nov 26 fa9812e31415e, so I think this is indeed the cause.

Change 574726 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/puppet@production] make mwscriptwikiset respect comments set in dblists

https://gerrit.wikimedia.org/r/574726

Mentioned in SAL (#wikimedia-operations) [2020-02-25T12:33:04Z] <Urbanecm> Run mwscript updateSpecialPages.php --wiki=enwiki --override --only=Wantedtemplates, cron didn't do that for several months (T246063)

Mentioned in SAL (#wikimedia-operations) [2020-02-25T13:00:17Z] <Urbanecm> Run mwscript updateSpecialPages.php --wiki=enwiki --override --only=Uncategorizedcategories, cron didn't do that for several months (T246063)

Urbanecm renamed this task from Special:WantedTemplates cronjob not running on enwiki to Special:WantedTemplates cronjob not running on all wikis.Feb 25 2020, 1:03 PM
Urbanecm claimed this task.

The issue was fixed by changing the mwscriptwikiset script to respect the comments.