Task breakdown discussion:

Options:

• Use Vue
  • The design system is in the works currently so we can't use it
  • When we estimated this task we assumed that we were going to use Vue
• Use OOUI
  • OOUI already has a version of the things we need (see Dialogues in https://doc.wikimedia.org/oojs-ui/master/demos)
  • Path of least resistance
  • We used OOUI components for the notice message page that we recently did (special list properties)

We posed the question of which to go with and decided the OOUI approach.
We reflected on the fact that it would be great if the component system was ready to use, and had such a component, and then we would use it! :)

Breakdown points:

• Use OOUI
• Do not immediately include the checkbox for popup impression (as we won't implement that functionality as part of this ticket (will be done in T251102))
• Create JS module to be loaded on pages which have the property links we want to trigger on
• Load that module on the pages, when federated properties is enabled
  • Item pages
  • Pages that use summaries (history, recent changes etc (same as the hook that we have been touching recently))

Questions:

• The BDD says "revision history", but doesn't this actually mean anywhere the edit summary is shown currently (including recent changes etc)
  • @Samantha_Alipio_WMDE
• Do we want to knowingly deviate from the default location of the X for OOUI for this pop up?
  • @Samantha_Alipio_WMDE
• What should be the behaviour if the JS hasn't loaded yet? (clicking real fast)
  • We assume that they are just allowed to click the link and navigate to the remote site (this is easiest)
• We had some thoughts regarding having fed props enabled browser tests in CI (not there yet) and wondered if we should look at that as part of this

We ran out of time slightly at the end but this is where we got.
Will post in mattermost to get a little bit of review as we didn't get to discuss how we might want to split this, and we also have option questions.

@Addshore thanks for the ping, here are my thoughts:

1. Good catch, what we'd be looking for is anywhere the edit summary is shown (revision history, recent changes) vs. just on revision history. Will update the ticket
2. Sarai will update the design with the OOUI default x location (thanks Sarai!)
3. I agree with your assumption that if JS hasn't loaded yet, user can just click the link and navigate to the source Wiki

Breakdown points:

• Use OOUI
• Do not immediately include the checkbox for popup impression (as we won't implement that functionality as part of this ticket (will be done in T251102))
• Create JS module to be loaded on pages which have the property links we want to trigger on
• Load that module on the pages, when federated properties is enabled
  • Item pages
  • Pages that use summaries (history, recent changes etc (same as the hook that we have been touching recently))
    • This might end up using a high-level hook to figure this out (something that runs on most page loads), or something low level (like the actual onHtmlPageLinkRendererEnd hook), or something else entirely (some other more specific hook)

Breakdown:

• Write the thing (js module)
  • Hook the thing up for Item Pages
• Hook the thing up for the summary related pages

Verified in the test system