Page MenuHomePhabricator
Create Task
Maniphest T246213

Template namespace no longer support subpages in some Wikis
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

Go to any template subpages in selected wikis, and it no longer show the "breadcrumb" navigation below the title.
Also, {{SUBPAGENAME}} gives the full title, not subpage name.

Obviously I have not made an exhaustive search, but so far i have found the following wikis to fail:

Wikisource (all so far)
Wikibooks (es:, fr:, it: and ca:, but not in en:)

And it seems to be working fine in

Wikipedia, Commons, Wikispecies, Wikivoyage, Wikiquote, Wikiversity, Meta, Mediawiki.... (all languages i've checked)

It seems to be related to the new Mediawiki version implemented.

It causes some templates to stop working (e.g. the ones using {{SUBPAGENAME}} )

Details

SubjectRepoBranchLines +/-
SiteConfiguration: Optimise getSetting() internals for getAll()mediawiki/corewmf/1.35.0-wmf.22+85 -61
SiteConfiguration: Optimise getSetting() internals for getAll()mediawiki/coremaster+85 -61
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ninovolador created this task.Feb 26 2020, 11:42 AM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptFeb 26 2020, 11:42 AM
MarcoAurelio added a project: Wikimedia-Site-requests.Feb 26 2020, 11:45 AM
MarcoAurelio subscribed.
This comment was removed by MarcoAurelio.
Kizule subscribed.Feb 26 2020, 11:47 AM

@MarcoAurelio I'm not sure that this is for Wikimedia-Site-requests.

MarcoAurelio added a comment.Feb 26 2020, 11:51 AM
In T246213#5919419, @Zoranzoki21 wrote:

@MarcoAurelio I'm not sure that this is for Wikimedia-Site-requests.

I'm not sure either but I think WMF-General-or-Unknown might be too vague. Feel free to change the tags if you think there's a more appropriate one.

Urbanecm subscribed.Feb 26 2020, 11:51 AM
[urbanecm@mwmaint1002 ~]$ mwscript shell.php metawiki
Psy Shell v0.9.12 (PHP 7.2.26-1+0~20191218.33+debian9~1.gbpb5a340+wmf1 — cli) by Justin Hileman
>>> $wgNamespacesWithSubpages[NS_TEMPLATE]
=> true
>>>

config appears to be correct.

MarcoAurelio added a project: WMF-General-or-Unknown.Feb 26 2020, 11:52 AM
Urbanecm edited projects, added MediaWiki-General; removed Wikimedia-Site-requests.Feb 26 2020, 12:01 PM
Urbanecm added a comment.Feb 26 2020, 12:15 PM

cnr at meta nor testwiki. Can anyone reproduce this?

Ninovolador added a comment.EditedFeb 26 2020, 2:06 PM

@Urbanecm Can you do the same check with the wikis I mentioned in the original post? eswikisource, enwikisource, eswikibooks for example.
The bug isn't currently affecting Meta...

Jdforrester-WMF subscribed.Feb 26 2020, 5:23 PM

Example failue URL: https://fr.wikibooks.org/wiki/Mod%C3%A8le:M%C3%A9ta_palette_de_navigation/Documentation/Exemple_5

Config has NS_TEMPLATE on by default, not overridden for wikibooks (though it does enable it for NS_MAIN, which is fine, and disable it for NS_MEDIAWIKI, which is rather bizzare), and not over-ridden for frwikibooks.

Not sure where in config it's getting mis-set.

Jdforrester-WMF added a project: Wikimedia-Site-requests.Feb 26 2020, 5:24 PM
Jdforrester-WMF added a comment.Feb 26 2020, 5:32 PM

Eyeballing cat wmf-config/config-cache/conf-production-*.json | jq '.wgNamespacesWithSubpages."8"', about half of wikis have it set to false,

Picking German, NS_TEMPLATE should be false for Wikipedia and Wikiversity and true otherwise, but is instead false on Wikibooks and Wikisource as well.

matmarex subscribed.Feb 27 2020, 8:50 PM
Krinkle added a subtask: T246858: SiteConfiguration arrayMerge() seems to corrupt numerical keys.Mar 4 2020, 2:12 AM
gerritbot added a comment.Mar 4 2020, 2:12 AM

Change 576483 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] SiteConfiguration: Optimise getSetting() internals for getAll()

https://gerrit.wikimedia.org/r/576483

gerritbot added a project: Patch-For-Review.Mar 4 2020, 2:12 AM
gerritbot added a comment.Mar 4 2020, 2:48 AM

Change 576483 merged by jenkins-bot:
[mediawiki/core@master] SiteConfiguration: Optimise getSetting() internals for getAll()

https://gerrit.wikimedia.org/r/576483

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 4 2020, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 4 2020, 3:10 AM
gerritbot added a comment.Mar 4 2020, 3:51 PM

Change 576864 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@wmf/1.35.0-wmf.22] SiteConfiguration: Optimise getSetting() internals for getAll()

https://gerrit.wikimedia.org/r/576864

gerritbot added a project: Patch-For-Review.Mar 4 2020, 3:51 PM
gerritbot added a comment.Mar 5 2020, 2:37 AM

Change 576864 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.22] SiteConfiguration: Optimise getSetting() internals for getAll()

https://gerrit.wikimedia.org/r/576864

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:01 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 5 2020, 3:10 AM
Krinkle closed subtask T246858: SiteConfiguration arrayMerge() seems to corrupt numerical keys as Resolved.Mar 5 2020, 3:36 AM
matmarex closed this task as Resolved.Mar 5 2020, 10:03 AM
matmarex assigned this task to Krinkle.

This seems to be resolved by the subtask. The page https://fr.wikibooks.org/wiki/Modèle:Méta_palette_de_navigation/Documentation/Exemple_5 now has breadcrumbs. mw.config.get( 'wgVisualEditorConfig' ).namespacesWithSubpages also returns the expected value, matching the configuration (e.g. namespace 10 "Template"/"Modèle" has subpages).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL