Page MenuHomePhabricator

Reload page after saving+purging is done
Closed, ResolvedPublic

Description

After the Bridge has successfully saved, we want to reload the page instead of closing the dialog, so that users will see the updated information.

This happens in the init module (see subscribeToEvents). The app already emits different events for save vs. cancel, no change should be necessary there.

A simple location.reload() should be fine.

Note: it’s possible that some other code will block the reload via the onbeforeunload event, e. g. to warn of unsaved changes being lost. This is acceptable – if the other code thinks the window shouldn’t be reloaded without warning, we should not reload it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2020, 2:32 PM

Change 577212 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Reload page after edit is saved

https://gerrit.wikimedia.org/r/577212

Change 577212 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Reload page after edit is saved

https://gerrit.wikimedia.org/r/577212

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 6 2020, 5:48 PM