Add additional information to bridge config API module
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Feb 26 2020, 2:59 PM

Description

The Bridge needs the following additional information from the repo:

URL of the terms of use
URL of the license
name of the license

Return it as part of the wbdatabridgeconfig API module.

Details

	Subject	Repo	Branch	Lines +/-
	bridge: Add license settings to config API module	mediawiki/extensions/Wikibase	master	+83 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Charlie_WMDE	T238728 Step 1: inform about editing on a different project under different license (impact: high)
		Resolved		Michael	T246225 Add additional information to bridge config API module

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 26 2020, 2:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2020, 2:59 PM

• Tonina_Zhelyazkova_WMDE edited projects, added Wikidata-Bridge; removed Wikidata-Bridge-Sprint-15.Feb 26 2020, 3:37 PM

Michael moved this task from Incoming to Task overflow on the Wikidata-Bridge board.Feb 26 2020, 3:38 PM

Michael claimed this task.Mar 5 2020, 11:18 AM

Michael edited projects, added Wikidata-Bridge-Sprint-15, User-Michael; removed Wikidata-Bridge.

Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-15 board.

Change 577229 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Bridge: Add license settings to config API module

https://gerrit.wikimedia.org/r/577229

gerritbot added a project: Patch-For-Review.Mar 5 2020, 12:37 PM

It seems the Terms of Use are not actually configured, but instead hard-coded win WikimediaMessages?

The wikibase-shortcopyrightwarning message gets the “terms of use” link target as a $2 parameter, the code must have it somewhere.

Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-15 board.Mar 5 2020, 2:13 PM

In T246225#5944834, @Lucas_Werkmeister_WMDE wrote:

The wikibase-shortcopyrightwarning message gets the “terms of use” link target as a $2 parameter, the code must have it somewhere.

It’s a bit convoluted (via CopyrightMessageBuilder and SpecialPageCopyrightView), but in the end I believe that URL comes from $settings->getSetting( 'dataRightsUrl' ) (in repo/Wikibase.php, where $settings is WikibaseRepo::getDefaultInstance()->getSettings()).

No, sorry, I got that wrong. the dataRightsUrl becomes, together with the dataRightsText, the $3 argument to wikibase-shortcopyrightwarning, which is the license link. $2 comes from CopyrightMessageBuilder::renderCopyrightPageMessage(), which is the copyrightpage message (but in the content language).