Page MenuHomePhabricator

Add small version of close/cancel button
Closed, ResolvedPublic

Event Timeline

“Small” here means “size M”, i. e. 32px high just like the ordinary size-M EventEmittingButton. See Bridge Figma and WiKit Figma.

@Charlie_WMDE as far as I can tell, the close icon itself is currently 14×14 in all sizes in the app. That’s convenient for me as the assignee of this task, because 14×14 is the intended size of the icon and I don’t need to do anything :) – but the WiKit Figma also says that the icon should grow to 16×16 for size L and 20×20 for size XL, which we currently don’t do. The Wikidata Bridge Figma, on the other hand, seems to have the icon at 20×20 for size L already, at least in the Global Bridge Specs section. I’m not sure where that leaves us… does that mean we need more fixes for the app?

the close icon itself is currently 14×14 in all sizes in the app

(Side note: the computed background-size is 20px, but the image itself contains some padding. I got the 14px by zooming in and using the “measure a portion of the page” tool.)

Change 577609 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add size M for icon-only EventEmittingButton

https://gerrit.wikimedia.org/r/577609

Change 577609 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add size M for icon-only EventEmittingButton

https://gerrit.wikimedia.org/r/577609

Charlie_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-16 board.

icon size of license banner looks good but we realised the other icon sizes are not correct. making a new ticket for that and moving this one to done.