Page MenuHomePhabricator

Browser tests for license modal
Closed, ResolvedPublic

Event Timeline

Change 579581 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Wire up License

https://gerrit.wikimedia.org/r/579581

Change 579581 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Wire up License

https://gerrit.wikimedia.org/r/579581

I consider this implemented, but please have a look and let me know if there should be more testing done for this.

I was thinking that a test for no change being saved when you don’t acknowledge the license popup could be added, but I’m not sure if that’s worth it.

I was thinking that a test for no change being saved when you don’t acknowledge the license popup could be added, but I’m not sure if that’s worth it.

So a separate test instead or in addition to clicking the cancel button in one of the tests: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/579581/12/client/data-bridge/tests/selenium/specs/canSave.js ?

I’m not sure what the test would look like – it could just click the save button once, or click that and then cancel the license popup, or do that but then click the save button again (but then still leave the license popup open without saving again)…

And as I said I’m not sure if this is worth it at all. We already have more detailed non-browser tests for this, after all.

Change 580071 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Add test for license closing behavior

https://gerrit.wikimedia.org/r/580071

I added an extra e2e test, there the trade-offs might be worth it more 🙂

Change 580071 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Add test for license closing behavior

https://gerrit.wikimedia.org/r/580071