Page MenuHomePhabricator

Add License component
Closed, ResolvedPublic

Description

  • Create a License component which looks like the mock in the parent task (minus the checkbox).
  • Create the necessary messages.
  • The component should emit a cancel event when the cancel button is clicked,
  • The “main body” of the text is probably one interface message (possibly two, one per paragraph), with parameters for the “publish changes” message name, the terms of use URL, the license name, and the license URL.
  • The “heading” may or may not be a separate interface message.

Figma Screenshot:

Event Timeline

Since T246229: Add component for dialog with semi-opaque overlay was merged into this task, I assume its scope also includes the overlay part?

Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-15 board.

Claiming the messages part for now.

Change 578350 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add messages for license dialog

https://gerrit.wikimedia.org/r/578350

Unassigning myself, anyone is free to continue. (That includes me, of course, it just doesn’t have to be me.)

Change 578350 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add messages for license dialog

https://gerrit.wikimedia.org/r/578350

Change 578565 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Add license component

https://gerrit.wikimedia.org/r/578565

Since T246229: Add component for dialog with semi-opaque overlay was merged into this task, I assume its scope also includes the overlay part?

@Michael the semi-transparent overlay isn’t part of your change, right? Or did I miss it?

@Michael the semi-transparent overlay isn’t part of your change, right? Or did I miss it?

Nevermind, I see it in the wire-up change now – I guess it makes sense there, too, since the app already knows how to “blur” itself during saving.

Change 578565 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Add license component

https://gerrit.wikimedia.org/r/578565

I think we can close this then, verification is probably better as part of the overall task.