Page MenuHomePhabricator

Cancel button is not accessible by the keyboard
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Navigate to Source Editor
  2. Cancel button not in logical tab order of "Save Changes", "Show Changes" and "Show preview"

Actual Results
Cancel button not in logical tab order

Expected Results:
Cancel tab order must be logical.

Event Timeline

Change 575069 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/core@master] Fix: When page loads, cancel button doesn't get focus when user hits the tab button continuously. Hence tabbing is not intuitive to keyboard only users. Adding a tabindex property to the cancel button to force the button to belong in the same tab order as "Save Changes", "Show Preview" and "Show Changes" button .

https://gerrit.wikimedia.org/r/575069

Change 575069 merged by jenkins-bot:
[mediawiki/core@master] editpage: Set tab index on "Cancel" button that follows the other buttons

https://gerrit.wikimedia.org/r/575069

Thanks for the patch! :) If there is nothing left to do here, please feel free to resolve this task via the Add Action...Change Status dropdown. Thanks!