Page MenuHomePhabricator

Responsive monobook preference should be listed under a section "Monobook preferences" a la Vector
Closed, ResolvedPublic

Description

In Vector a "Vector preferences" section appears when the "vector" skin radio button is selected (see https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering)

In Monobook a Monobook specific preference (responsive mode) only shows when the user hits save.

This task aims to make the two workflows consistent with a core change that also resolves T246162

QA steps

  • Make sure Vector skin is selected
  • Visit Special:preferences
  • Click Monobook

Expected: I see the Monobook preference.
Actual: I don't see it until I hit save.

Acceptance criteria

  • The Monobook specific option is revealed as soon as you select the radio button. When another radio button is selected it is hidden.
  • The Monobook specific option appears under a heading "Monobook skin preferences" when you select the radio button.
  • When selecting the Vector skin a Vector specific option appears under a heading "Vector skin preferences". The Monobook skin is no longer shown
  • The skin preference section appears directly under the skins and is the first section in preferences.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2020, 11:20 PM

Change 575099 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] Reveal Monobook "enable responsive design" option when skin selected

https://gerrit.wikimedia.org/r/575099

Change 575103 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Generalise skin preferences so it can be used by Monobook

https://gerrit.wikimedia.org/r/575103

Change 575103 merged by jenkins-bot:
[mediawiki/core@master] Generalise skin preferences so it can be used by Monobook

https://gerrit.wikimedia.org/r/575103

Change 575099 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Reveal Monobook "enable responsive design" option when skin selected

https://gerrit.wikimedia.org/r/575099

matmarex closed this task as Resolved.Feb 29 2020, 1:11 AM
matmarex assigned this task to Jdlrobson.
matmarex added a subscriber: matmarex.

Change 577340 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Documentation: Correct typo and use mw.org as preferred doc source

https://gerrit.wikimedia.org/r/577340

Change 577340 abandoned by Jdlrobson:
Documentation: Correct typo and use mw.org as preferred doc source

Reason:
Pending further discussion on a future ticket.

https://gerrit.wikimedia.org/r/577340