Page MenuHomePhabricator
Create Task
Maniphest T246304

OnlineStatusBar needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Description

See parent task

Details

SubjectRepoBranchLines +/-
Remove use of $wgUsermediawiki/extensions/OnlineStatusBarmaster+23 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Feb 27 2020, 3:52 AM
DannyS712 created this task.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 27 2020, 3:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Feb 27 2020, 3:53 AM

Change 575120 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/OnlineStatusBar@master] Remove use of $wgUser (part 1)

https://gerrit.wikimedia.org/r/575120

gerritbot added a project: Patch-For-Review.Feb 27 2020, 3:53 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Feb 27 2020, 3:55 AM

Codesearch: https://codesearch.wmflabs.org/things/?q=global%5B%5E%3B%5D%2B%5C%24wgUser%5B%2C%3B%5D&i=nope&files=&repos=Extension:OnlineStatusBar

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Feb 27 2020, 3:57 AM

Easier than I thought - doing it all in one patch

gerritbot added a comment.Feb 27 2020, 4:22 AM

Change 575120 merged by jenkins-bot:
[mediawiki/extensions/OnlineStatusBar@master] Remove use of $wgUser

https://gerrit.wikimedia.org/r/575120

DannyS712 closed this task as Resolved.Feb 27 2020, 4:25 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Mar 4 2020, 7:54 AM
DannyS712 added a parent task: T247793: Non-WMF deployed extensions need uses of global $wgUser removed [tracking].Mar 16 2020, 9:49 PM
DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL