Groups are not removed in MW if the attribute is not existing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Markus.T
	Feb 27 2020, 3:34 PM

Description

Hi there again,

I found another bug.

I added a group mapping between my identity provider and the service provider. It works fine, but when I remove the user from the group (on the identity provider) the group is only removed in MediaWiki if the SAML attribute is still exisiting (becuase there is another entry). If it was the only entry of the SAML attribute, the user is not removed from the group on MediaWiki side because the attribute is no more provided by the service provider.

Kind regards
Markus

Event Timeline

Markus.T created this task.Feb 27 2020, 3:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2020, 3:34 PM

@Markus.T Thank you for the report.

@Osnard Do you have any thoughts on this?

I can confirm this. I have added a UnitTest to check the behavior and also added a fix: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SimpleSAMLphp/+/575481

All UnitTests pass, so @cicalese it's up to you to merge it.

Sorry for the delay! It is now merged. I bumped the version number and tagged the release.

cicalese closed this task as Resolved.Apr 12 2020, 10:13 PM

cicalese claimed this task.

cicalese moved this task from Backlog to Closed on the MediaWiki-extensions-SimpleSAMLphp board.Jun 3 2023, 2:28 PM

Groups are not removed in MW if the attribute is not existingClosed, ResolvedPublicActions

Description

Event Timeline

Groups are not removed in MW if the attribute is not existing
Closed, ResolvedPublic
Actions