Page MenuHomePhabricator

Mute: Don't allow muting yourself
Open, Needs TriagePublicBUG REPORT

Description

Special:Mute allows to mute yourself via Special:Mute/<your_username_here>.

That should not be possible given that it'll have no effect either.

Tested at 2020-02-27 on mediawiki.org running on MediaWiki 1.35.0-wmf.21 (rMWa1086988f12f).

Event Timeline

MarcoAurelio changed the subtype of this task from "Task" to "Bug Report".Feb 27 2020, 8:31 PM

@MarcoAurelio Thanks for reporting this. I agree it's a valid bug though I'll admit this was super handy for testing, :)

This is what I noticed and opened T245108. Disabling the link is almost as effective (by obscuring) but it would not hurt to disable the action altogether though.

@MarcoAurelio Thanks for reporting this. I agree it's a valid bug though I'll admit this was super handy for testing, :)

I think this can tested only for email but would not be possible for ping since one cannot ping oneself in the first place.

Change 576906 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Disable muting oneself

https://gerrit.wikimedia.org/r/576906

One thing to keep in mind is that there is nothing preventing yourself from adding your own username to the email or echo blacklists via Special:Preferences. That was one of the reasons why we didn't enforce this rule IIRC. I do not disagree with hiding the link when it applies tho.

Change 576906 abandoned by Ammarpad:
[mediawiki/core@master] Disable muting oneself

Reason:
Probably not needed

https://gerrit.wikimedia.org/r/576906

Change 642445 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/libs/ObjectFactory@master] Allow injecting configuration values

https://gerrit.wikimedia.org/r/642445