Page MenuHomePhabricator

Deprecate LogEventsList::typeAction use of $wgUser
Closed, ResolvedPublic

Description

LogEventsList::typeAction accepts as a fourth parameter an optional right. When set, it checks if $wgUser has that right
Rather than adding a user parameter, its simpler to just deprecate and then remove the right-checking functionality, which is unused (https://codesearch.wmflabs.org/search/?q=%3A%3AtypeAction&i=nope&files=&repos=) - if it is ever needed again, it can be added with a user parameter as well

Event Timeline

Change 575406 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate requiring a right in LogEventsList::typeAction

https://gerrit.wikimedia.org/r/575406

DannyS712 renamed this task from LogEventsList::typeAction uses $wgUser to Deprecate LogEventsList::typeAction use of $wgUser.Feb 28 2020, 6:29 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.

Change 575406 merged by jenkins-bot:
[mediawiki/core@master] Deprecate requiring a right in LogEventsList::typeAction

https://gerrit.wikimedia.org/r/575406