Page MenuHomePhabricator

Use new Sass module system
Open, Stalled, Needs TriagePublic

Description

Since October 2019, Sass has a new module system, which alleviates several problems with the old import system. I suspect this would solve several problems in our Data Bridge CSS, including duplicate license header comments in the built data-bridge.css. But we can’t use it yet, because it’s not supported by LibSass (sass/libsass#2807). Once it is, we should migrate to it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lucas_Werkmeister_WMDE changed the task status from Open to Stalled.Feb 28 2020, 9:46 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Tech/Ready-ish on the Wikidata-Bridge board.

LibSass is now deprecated and will never gain support for the new module system, so I guess this task is now stalled until this proposed replacement based on an embedded protocol materializes in a form we can use.

Change 754561 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] bridge: switch from node-sass to sass and update sass-loader

https://gerrit.wikimedia.org/r/754561

Change 754561 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] bridge: switch from node-sass to sass and update sass-loader

https://gerrit.wikimedia.org/r/754561