These are the patches I see waiting for review (aside from Geotargeting and Banner templates). Do we have others @AndyRussG?

• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/576528
• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/549202
• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/498480

In T246461#5945348, @mepps wrote:

These are the patches I see waiting for review (aside from Geotargeting and Banner templates). Do we have others @AndyRussG?

• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/576528
• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/549202
• https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/498480

That looks right! All the others seem pretty old or have merge conflicts, which could be fixed by the patch authoers (detailes here).

Here are the patches I see waiting to be deployed:

1e58615b Stop using old deprecated SpecialPageFactory static functions
527a7001 eslint: Add /mediawiki rules
56a3269e Fix IDatabase::upsert() calls with bad unique key parameters
52537a88 composer: Bump mediawiki-phan-config to 0.9.2
57770bf8 Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser
b9a9b6ac Avoid pointless use of $wgMemc
49e7b9e4 Replace use of rc_new field with rc_source
7220d43b Remove uses of global $wgUser as a fallback
679a23c7 Remove unused function
0bad753b Use IDatabase::buildLike
0827564b Remove wrong default value from WebRequest::getText call
ac0f850d Remove pre RecentChange::getQueryInfo code

The only deprecation warning I see from CentralNotice currently on production is regarding WebRequest::getLimitOffset (see this logstash result). I don't see on the related task info about when the method will be removed.

Also note that at least basic CN banner display and Admin UI functionality seem fine on the Beta cluster.

Also, before we merge master to wmf_deploy we should properly revert this change that was accidentally +2'ed only on the wmf_deploy. (We thought we'd reverted it but the revert patch in the end didn't merge because of CI. The version of the change on master is waiting for an update from the author.)

I +2ed one of the patches above. Another is from Sept 2019 and has a comment waiting for reply. The third I +1ed but I wasn't clear about the context on the page we were deleting. I saw a Phab task about it but don't know enough of the history of the CNReporter page to feel comfortable +2ing that patch.

Also @AndyRussG how do we get that change to revert?

@AndyRussG what day should we merge the outstanding commits to master?

Hi! Here's some documentation I made about this process.

In T246461#5960932, @mepps wrote:

@AndyRussG what day should we merge the outstanding commits to master?

I'd recommend a Friday or a Monday.

Also @AndyRussG how do we get that change to revert?

I re-ran the CI and it seems OK now, so it just needs someone else to +2 it again.

Change 580173 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/580173

Change 580173 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/580173