Page MenuHomePhabricator
Create Task
Maniphest T246528

Enable PHPCS
Closed, ResolvedPublic
Actions

Description

The extension needs to meet and pass our PHP coding standards

Details

SubjectRepoBranchLines +/-
Add phpcs and phanmediawiki/extensions/NearbyPagesmaster+43 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT246493 [EPIC] Deploy NearbyPages everywhere
 ResolvedKizuleT246528 Enable PHPCS

Event Timeline

Reedy created this task.Feb 29 2020, 11:24 AM
Kizule claimed this task.Feb 29 2020, 12:52 PM
Kizule subscribed.

Sure, let's do this.

Restricted Application added a project: User-Kizule. · View Herald TranscriptFeb 29 2020, 12:52 PM
Kizule mentioned this in T246527: Enable phan and seccheck.Feb 29 2020, 12:57 PM
gerritbot added a comment.Feb 29 2020, 1:02 PM

Change 575685 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/NearbyPages@master] Add phpcs and phan

https://gerrit.wikimedia.org/r/575685

gerritbot added a project: Patch-For-Review.Feb 29 2020, 1:02 PM
Kizule moved this task from Backlog to Needs review / blocked on the NearbyPages board.Feb 29 2020, 1:09 PM
gerritbot added a comment.Feb 29 2020, 2:52 PM

Change 575685 merged by jenkins-bot:
[mediawiki/extensions/NearbyPages@master] Add phpcs and phan

https://gerrit.wikimedia.org/r/575685

Reedy closed this task as Resolved.Feb 29 2020, 2:53 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 29 2020, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL