Avoid use of User::isAllowed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ammarpad
	Mar 1 2020, 9:57 AM

Description

User::isAllowed has been deprecated since 1.34, but it's still being added in new code. All calls should be replaced with PermissionManager

Details

	Subject	Repo	Branch	Lines +/-
	OAuth: Replace User::isAllowed calls with PermissionManager.	mediawiki/extensions/OAuth	master	+82 -26

Customize query in gerrit

Related Objects

Mentioned In: T265361: OAuth extension - get rid of isAllowed() deprecated method

Event Timeline

Ammarpad created this task.Mar 1 2020, 9:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2020, 9:57 AM

Ammarpad triaged this task as Medium priority.Mar 1 2020, 9:57 AM

Change 575768 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/OAuth@master] OAuth: Replace User::isAllowed with PermissionManager.

https://gerrit.wikimedia.org/r/575768

gerritbot added a project: Patch-For-Review.Mar 1 2020, 10:06 AM

Aklapper added a project: Technical-Debt.Mar 1 2020, 1:11 PM

Ammarpad mentioned this in T265361: OAuth extension - get rid of isAllowed() deprecated method.Oct 13 2020, 9:41 PM

Change 575768 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] OAuth: Replace User::isAllowed calls with PermissionManager.

https://gerrit.wikimedia.org/r/575768

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 15 2020, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2020, 7:11 PM

Ammarpad closed this task as Resolved.Oct 21 2020, 7:40 AM

Ammarpad claimed this task.

Aklapper merged a task: T265361: OAuth extension - get rid of isAllowed() deprecated method.Oct 23 2023, 12:05 PM

Aklapper added subscribers: Art.tsymbar, Vlad.shapik.

Avoid use of User::isAllowedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Avoid use of User::isAllowed
Closed, ResolvedPublic
Actions